Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to event_source_mapping and alias_ref for namespace reference check #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Jul 29, 2024

Issue #1777

Description of changes:
*Adding new e2e test suites to validate our recently introduced feature "cross namespace resource references". In order to test this feature, we added a new feature to allow new namespace creation, from which resources will be referenced (alias and event source mapping in this case).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and valerena July 29, 2024 23:38
Copy link

ack-prow bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm michaelhtm force-pushed the namespaceReferenceTest branch 14 times, most recently from 9f37b32 to c43f4f8 Compare July 30, 2024 20:18
@michaelhtm michaelhtm force-pushed the namespaceReferenceTest branch 12 times, most recently from 02a84db to 00130a5 Compare August 2, 2024 19:48
@michaelhtm michaelhtm force-pushed the namespaceReferenceTest branch 2 times, most recently from 59e1425 to 165c2ec Compare August 2, 2024 20:27
Copy link

ack-prow bot commented Aug 30, 2024

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lambda-kind-e2e 3b496ed link true /test lambda-kind-e2e
lambda-verify-attribution 3b496ed link true /test lambda-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant