Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.38.0, code-generator v0.38.1 #148

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Aug 29, 2024

Update to ACK runtime v0.38.0, code-generator v0.38.1



NOTE:
This PR increments the release version of service controller from v1.5.1 to v1.5.2

Once this PR is merged, release v1.5.2 will be automatically created for lambda-controller

Please close this PR, if you do not want the new patch release for lambda-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building lambda-controller ====
Copying common custom resource definitions into lambda
Building Kubernetes API objects for lambda
Generating deepcopy code for lambda
Generating custom resource definitions for lambda
Building service controller for lambda
Generating RBAC manifests for lambda
Running gofmt against generated code for lambda
Updating additional GitHub repository maintenance files
==== building lambda-controller release artifacts ====
Building release artifacts for lambda-v1.5.2
Generating common custom resource definitions
Generating custom resource definitions for lambda
Generating RBAC manifests for lambda

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Aug 29, 2024
@michaelhtm
Copy link
Member

/retest

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@michaelhtm
Copy link
Member

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@michaelhtm
Copy link
Member

/retest

5 similar comments
@michaelhtm
Copy link
Member

/retest

@michaelhtm
Copy link
Member

/retest

@michaelhtm
Copy link
Member

/retest

@michaelhtm
Copy link
Member

/retest

@michaelhtm
Copy link
Member

/retest

Copy link

ack-prow bot commented Aug 30, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lambda-verify-attribution 7a75d61 link false /test lambda-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024
Copy link

ack-prow bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Sep 10, 2024
@ack-prow ack-prow bot merged commit 1a7044a into main Sep 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants