Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.33.0, code-generator v0.33.0 #64

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Mar 29, 2024

Update to ACK runtime v0.33.0, code-generator v0.33.0



NOTE:
This PR increments the release version of service controller from v1.0.9 to v1.0.10

Once this PR is merged, release v1.0.10 will be automatically created for sfn-controller

Please close this PR, if you do not want the new patch release for sfn-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sfn-controller ====
Copying common custom resource definitions into sfn
Building Kubernetes API objects for sfn
Generating deepcopy code for sfn
Generating custom resource definitions for sfn
Building service controller for sfn
Generating RBAC manifests for sfn
Running gofmt against generated code for sfn
Updating additional GitHub repository maintenance files
==== building sfn-controller release artifacts ====
Building release artifacts for sfn-v1.0.10
Generating common custom resource definitions
Generating custom resource definitions for sfn
Generating RBAC manifests for sfn

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Mar 29, 2024
@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 March 29, 2024 14:21
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
Copy link

ack-prow bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 29, 2024
@ack-prow ack-prow bot merged commit 1b2f098 into main Mar 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants