Add support for WebACL CRD #14
Conversation
TiberiuGC
force-pushed
the
resource/web-acls
branch
from
0d22636
to
d392f73
Compare
|
@TiberiuGC: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| - WebACL.Rules.Statement.OrStatement | ||
| - WebACL.Rules.Statement.NotStatement | ||
| - WebACL.Rules.Statement.ManagedRuleGroupStatement.ScopeDownStatement | ||
| - WebACL.Rules.Statement.RateBasedStatement.ScopeDownStatement | ||
| model_name: wafv2 | ||
| empty_shapes: | ||
| - All |
There was a problem hiding this comment.
I'm glad we landed this feature. The more i think about it the more it sounds right.
| k8s.patch_custom_resource(ref, updates) | ||
| time.sleep(MODIFY_WAIT_SECONDS) |
There was a problem hiding this comment.
Something i recommend to do after updates is to validate the resource sync and not in terminal/requeue state. However i checked the logs and all it looks correct.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.