Fix user-data shebang newline issue #1168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User-data scripts has a newline before the shebang, causing the resulting script to be invalid. Writer already puts a newline: https://github.com/golang/go/blob/beaf7f3282c2548267d3c894417cc4ecacc5d575/src/mime/multipart/writer.go#L120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-data scripts has a newline before the shebang, causing the resulting script to be invalid.
Golang MIME multipart writer already puts a newline:
https://github.com/golang/go/blob/beaf7f3282c2548267d3c894417cc4ecacc5d575/src/mime/multipart/writer.go#L120
Removed said newline.
Fixes #1164
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.