chore(prlint): dismissed reviews should not count as requested changes (

#26552) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Jul 31, 2023 · 960d14a · 960d14a
1 parent cb97232
commit 960d14a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tools/@aws-cdk/prlint/lint.ts b/tools/@aws-cdk/prlint/lint.ts
@@ -358,7 +358,7 @@ export class PullRequestLinter {
     );
     const communityRequestedChanges = reviews.data.some(
       review => this.getTrustedCommunityMembers().includes(review.user?.login ?? '')
-        && review.state !== 'APPROVED', // community members cannot request changes
+        && review.state === 'COMMENTED', // community members can only approve or comment
     );
     const communityApproved = reviews.data.some(
       review => this.getTrustedCommunityMembers().includes(review.user?.login ?? '')

diff --git a/tools/@aws-cdk/prlint/test/lint.test.ts b/tools/@aws-cdk/prlint/test/lint.test.ts
@@ -743,7 +743,7 @@ describe('integration tests required on features', () => {
       mockListReviews.mockImplementation(() => {
         return {
           data: [
-            { id: 1111122223, user: { login: 'pahud' }, state: 'COMMENT' },
+            { id: 1111122223, user: { login: 'pahud' }, state: 'COMMENTED' },
           ],
         };
       });