Skip to content

Commit

Permalink
update feature flag naming
Browse files Browse the repository at this point in the history
  • Loading branch information
Michelle Wang committed Sep 20, 2024
1 parent 9d06b00 commit be56d45
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';

const app = new cdk.App({
postCliContext: {
'@aws-cdk.aws-ec2:ec2SumTImeoutEnabled': false,
'@aws-cdk/aws-ec2:ec2SumTImeoutEnabled': false,
},
});
const stack = new cdk.Stack(app, 'integ-init');
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ec2/lib/instance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ export class Instance extends Resource implements IInstance {
}

/**
* Apply CloudFormation update policies for the instance.
* Apply CloudFormation update policies for the instance
*/
private applyUpdatePolicies(props: InstanceProps) {
if (props.resourceSignalTimeout !== undefined) {
Expand Down
6 changes: 3 additions & 3 deletions packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Flags come in three types:
| [@aws-cdk/aws-s3:keepNotificationInImportedBucket](#aws-cdkaws-s3keepnotificationinimportedbucket) | When enabled, Adding notifications to a bucket in the current stack will not remove notification from imported stack. | 2.155.0 | (fix) |
| [@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask](#aws-cdkaws-stepfunctions-tasksusenews3uriparametersforbedrockinvokemodeltask) | When enabled, use new props for S3 URI field in task definition of state machine for bedrock invoke model. | 2.156.0 | (fix) |
| [@aws-cdk/aws-ecs:reduceEc2FargateCloudWatchPermissions](#aws-cdkaws-ecsreduceec2fargatecloudwatchpermissions) | When enabled, we will only grant the necessary permissions when users specify cloudwatch log group through logConfiguration | 2.159.0 | (fix) |
| [@aws-cdk.aws-ec2:ec2SumTImeoutEnabled](#aws-cdkaws-ec2ec2sumtimeoutenabled) | When enabled, initOptions.timeout and resourceSignalTimeout values will be summed together. | V2NEXT | (fix) |
| [@aws-cdk/aws-ec2:ec2SumTImeoutEnabled](#aws-cdkaws-ec2ec2sumtimeoutenabled) | When enabled, initOptions.timeout and resourceSignalTimeout values will be summed together. | V2NEXT | (fix) |

<!-- END table -->

Expand Down Expand Up @@ -138,7 +138,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou
"@aws-cdk/custom-resources:logApiResponseDataPropertyTrueDefault": false,
"@aws-cdk/aws-s3:keepNotificationInImportedBucket": false,
"@aws-cdk/aws-ecs:reduceEc2FargateCloudWatchPermissions": true,
"@aws-cdk.aws-ec2:ec2SumTImeoutEnabled": true
"@aws-cdk/aws-ec2:ec2SumTImeoutEnabled": true
}
}
```
Expand Down Expand Up @@ -1382,7 +1382,7 @@ When this feature flag is enabled, specify newly introduced props 's3InputUri' a
**Compatibility with old behavior:** Disable the feature flag to use input and output path fields for s3 URI


### @aws-cdk.aws-ec2:ec2SumTimeoutEnabled
### @aws-cdk/aws-ec2:ec2SumTimeoutEnabled

*When enabled, initOptions.timeout and resourceSignalTimeout values will be summed together.* (fix)

Expand Down
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/cx-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ _cdk.json_
}
```

* `@aws-cdk.aws-ec2:ec2SumTImeoutEnabled`
* `@aws-cdk/aws-ec2:ec2SumTImeoutEnabled`

Currently is both initOptions.timeout and resourceSignalTimeout are both specified in the options for creating an EC2 Instance, only the value from 'resourceSignalTimeout' will be used.

Expand All @@ -421,7 +421,7 @@ _cdk.json_
```json
{
"context": {
"@aws-cdk.aws-ec2:ec2SumTImeoutEnabled": true
"@aws-cdk/aws-ec2:ec2SumTImeoutEnabled": true
}
}
```
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/cx-api/lib/features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export const LOG_API_RESPONSE_DATA_PROPERTY_TRUE_DEFAULT = '@aws-cdk/custom-reso
export const S3_KEEP_NOTIFICATION_IN_IMPORTED_BUCKET = '@aws-cdk/aws-s3:keepNotificationInImportedBucket';
export const USE_NEW_S3URI_PARAMETERS_FOR_BEDROCK_INVOKE_MODEL_TASK = '@aws-cdk/aws-stepfunctions-tasks:useNewS3UriParametersForBedrockInvokeModelTask';
export const REDUCE_EC2_FARGATE_CLOUDWATCH_PERMISSIONS = '@aws-cdk/aws-ecs:reduceEc2FargateCloudWatchPermissions';
export const EC2_SUM_TIMEOUT_ENABLED = '@aws-cdk.aws-ec2:ec2SumTImeoutEnabled';
export const EC2_SUM_TIMEOUT_ENABLED = '@aws-cdk/aws-ec2:ec2SumTImeoutEnabled';

export const FLAGS: Record<string, FlagInfo> = {
//////////////////////////////////////////////////////////////////////
Expand Down

0 comments on commit be56d45

Please sign in to comment.