Issue while creating alarm rule from alarms having space in their name

[somanshusingla]

❓ General Issue

The Question

I was creating composite alarm using alarm rule AlarmRule.anyOf(...alarms) where why alarms had space in their alarm name and got a issue like this:

    13:01:24 | CREATE_FAILED        | AWS::CloudWatch::CompositeAlarm | composite-1
    Error in AlarmRule [Unsupported token 'Oldest' at char 67, must be: ')'] (Service: AmazonCloudWatch; Status Code: 400
    ; Error Code: ValidationError; Request ID: 8d5ac86f-3017-4802-bf61-0113bb093c25; Proxy: null)
     
     
    const oldestAgeAlarm = new Alarm(this, 'oldest-age', {
          metric: oldestAgeMetric,
          evaluationPeriods: 5,
          threshold: 608000,
          alarmName: "SampleQueue Oldest Age Alarm",
          alarmDescription: "SampleQueue Oldest Age more than 608000",
          comparisonOperator: ComparisonOperator.GREATER_THAN_THRESHOLD,
          datapointsToAlarm: 3,
          actionsEnabled: false
        })
     
        const visibleMessageAlarm = new Alarm(this, 'visible-message', {
            metric: messagesVisibleMetric,
            evaluationPeriods: 5,
            threshold: 2000000,
            alarmName: "SampleQueue Visible Messages Alarm",
            alarmDescription: "SampleQueue Visible Messages more than 2000000",
            comparisonOperator: ComparisonOperator.GREATER_THAN_THRESHOLD,
            datapointsToAlarm: 3,
            actionsEnabled: false
        })
     
        new CompositeAlarm(this, 'composite-1', {
            compositeAlarmName: 'This is sample composite alarm',
            alarmRule: AlarmRule.anyOf(...[oldestAgeAlarm, visibleMessageAlarm]),
            
        })

Looks like this can be solved by introducing double quotes her: https://github.com/aws/aws-cdk/blob/v1.95.1/packages/@aws-cdk/aws-cloudwatch/lib/alarm-base.ts#L54

I had to write my own alarm rule to solve this like:

export class AlarmRuleOR implements IAlarmRule {
  readonly alarmRule: string;

  constructor(alarms: IAlarm[]) {
    this.alarmRule = alarms
      .map((alarm) => `ALARM("${alarm.alarmName}")`)
      .join(" OR ");
  }

  renderAlarmRule(): string {
    return this.alarmRule;
  }
}

Using double quotes in share code reference like this will solve the issue.

[somanshusingla]

Creating a pull request for this.

[somanshusingla]

Pull Request: #13963

[peterwoodworth]

Thank you for contributing @S-T-O-C-H-A-S-T-I-C ! 😄

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.