Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rds: instance identifiers and endpoints not available on DatabaseCluster #14377

Closed
vilikin opened this issue Apr 26, 2021 · 2 comments · Fixed by #14394
Closed

aws-rds: instance identifiers and endpoints not available on DatabaseCluster #14377

vilikin opened this issue Apr 26, 2021 · 2 comments · Fixed by #14394
Assignees
@skinny85
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@vilikin
Copy link
Contributor

vilikin commented Apr 26, 2021

DatabaseCluster should have instanceIdentifiers and instanceEndpoints props available. However, it looks like these are always empty.

From the code we can see that those are not actually set to the right values returned by the createInstances method:

aws-cdk/packages/@aws-cdk/aws-rds/lib/cluster.ts

Line 527 in 55e737f

createInstances(this, props, this.subnetGroup);

Reproduction Steps

Create a DatabaseCluster with at least 1 instance and try to access instanceIdentifiers or instanceEndpoints prop. Those are always empty arrays.

This is 🐛 Bug Report
@vilikin vilikin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Apr 26, 2021
@skinny85
Copy link
Contributor

Thanks for opening the issue @vilikin. You are correct, I was able to reproduce the problem.

Any chance of submitting us a PR fixing this? It should be a fairly easy change. Here's our "Contributing" guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2021
vilikin pushed a commit to vilikin/aws-cdk that referenced this issue Apr 27, 2021
fix(aws-rds): allow accessing instance identifiers and endpoints of a…
7ba3f6d 
… cluster

Previously instanceIdentifiers and instanceEndpoints were readonly properties
of DatabaseClusterNew, defaulting to empty arrays. However, they they were
never set to the correct values after instances were added to the cluster.
Those properties are now moved on to the DatabaseCluster and
DatabaseClusterFromSnapshot classes where they can now actually be set to
correct values.

fixes aws#14377
@vilikin vilikin mentioned this issue Apr 27, 2021
Merged
@mergify mergify bot closed this as completed in #14394 Apr 29, 2021
mergify bot pushed a commit that referenced this issue Apr 29, 2021
@vilikin
fix(rds): instance identifiers and endpoints of a Cluster are blank (#…
9597d97 
…14394)

Previously instanceIdentifiers and instanceEndpoints were readonly properties of DatabaseClusterNew, defaulting to empty arrays. However, they they were never set to the correct values after instances were added to the cluster. Those properties are now moved on to the DatabaseCluster and DatabaseClusterFromSnapshot classes where they can now actually be set to correct values.

fixes #14377


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
@vilikin @john-tipper
fix(rds): instance identifiers and endpoints of a Cluster are blank (a…
a807134 
…ws#14394)

Previously instanceIdentifiers and instanceEndpoints were readonly properties of DatabaseClusterNew, defaulting to empty arrays. However, they they were never set to the correct values after instances were added to the cluster. Those properties are now moved on to the DatabaseCluster and DatabaseClusterFromSnapshot classes where they can now actually be set to correct values.

fixes aws#14377


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@vilikin @hollanddd
fix(rds): instance identifiers and endpoints of a Cluster are blank (a…
2dcbbf0 
…ws#14394)

Previously instanceIdentifiers and instanceEndpoints were readonly properties of DatabaseClusterNew, defaulting to empty arrays. However, they they were never set to the correct values after instances were added to the cluster. Those properties are now moved on to the DatabaseCluster and DatabaseClusterFromSnapshot classes where they can now actually be set to correct values.

fixes aws#14377


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rds): instance identifiers and endpoints of a Cluster are blank vilikin/aws-cdk
2 participants
@skinny85 @vilikin