-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(stepfunctions-tasks): AutoTerminationPolicy feature is not supported by Step Functions #17452
Comments
@frederic-schmaljohann sorry for the confusion! You are correct, the docs say "Step Functions does not terminate an Amazon EMR cluster automatically if execution is stopped." This was a miss on my part, I will look to revert the previous PR. |
@kaizen3031593 Ok, thank you. I don't think that the explanation is correct though, AutoTerminationPolicy is a feature provided by EMR and StepFunctions wouldn't need to terminate the cluster. However, passing the termination policy doesn't seem to be supported by StepFunctions. The documentation is not 100% correct here in my opinion: https://docs.aws.amazon.com/step-functions/latest/dg/connect-emr.html |
I agree, the documentation is not good here. I took the above sentence to maybe mean that Stepfunctions does not allow automatic termination to EMR clusters but even that is a stretch... I believe you, I'm going to have to get to the bottom of this and most likely deprecate the property. |
This reverts commit: #16976. `AutoTerminationPolicy` was never supported by stepfunctions, even though it is supported by EMR. This was not discovered until it was used since the documentation does not mention this limitation of stepfunctions. Since it never worked, we are okay with the breaking change here. Closes #17452.
|
This reverts commit: aws#16976. `AutoTerminationPolicy` was never supported by stepfunctions, even though it is supported by EMR. This was not discovered until it was used since the documentation does not mention this limitation of stepfunctions. Since it never worked, we are okay with the breaking change here. Closes aws#17452.
What is the problem?
I'm not sure but the following seems to me like a bug:
When I try to add the AutoTerminationPolicy in tasks.EmrCreateCluster, get the following error while deploying:
Invalid State Machine Definition: 'SCHEMA_VALIDATION_FAILED: The field "AutoTerminationPolicy" is not supported by Step Functions
I get the same error when I try to the AutoTerminationPolicy in the console when creating a cluster via Step Functions, which makes me wonder how this feature could even work.
This feature was introduced in cdk 1.132.0 with #16976
Thank you and regards
Frederic
Reproduction Steps
What did you expect to happen?
A state machine which starts an EMR cluster with AutoTerminationPolicy
What actually happened?
The schema of the state machine is invalid.
CDK CLI Version
1.132.0
Framework Version
No response
Node.js Version
17.0.1
OS
Mac OS
Language
Python
Language Version
3.9.7
Other information
No response
The text was updated successfully, but these errors were encountered: