Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudwatch: allow configuring period on SingleValueWidget #26259

Closed
1 of 2 tasks
humanzz opened this issue Jul 6, 2023 · 2 comments · Fixed by #26260
Closed
1 of 2 tasks

cloudwatch: allow configuring period on SingleValueWidget #26259

humanzz opened this issue Jul 6, 2023 · 2 comments · Fixed by #26260
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@humanzz
Copy link
Contributor

humanzz commented Jul 6, 2023

Describe the feature

SingleValue widget supports setting a period parameter as can be tested/verified via CloudWatch console.

The SingleValueWidget class and its props, do not expose a period prop.

Use Case

Being able to customize the period on SingleValueWidget

Proposed Solution

  • SingleValueWidgetProps to expose a period prop
  • SingleValueWidget.toJson to render the period correctly

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.85.0

Environment details (OS name and version, etc.)

macOS
@humanzz humanzz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 6, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Jul 6, 2023
@humanzz humanzz changed the title aws-cloudwatch: allow setting period on SingleValueWidget aws-cloudwatch: allow configuring period on SingleValueWidget Jul 6, 2023
@humanzz humanzz mentioned this issue Jul 6, 2023
Merged
@khushail
Copy link
Contributor

khushail commented Jul 6, 2023

Thanks for submitting the feature request and PR @humanzz. It would be reviewed by our team.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 6, 2023
@humanzz humanzz changed the title aws-cloudwatch: allow configuring period on SingleValueWidget cloudwatch: allow configuring period on SingleValueWidget Jul 7, 2023
@mergify mergify bot closed this as completed in #26260 Jul 7, 2023
mergify bot pushed a commit that referenced this issue Jul 7, 2023
@humanzz
feat(cloudwatch): allow configuring period on SingleValueWidget (#26260)
c8edc87 
- expose a period prop on `SingleValueWidgetProps`
- use the period prop when rendering `SingleValueWidget`

Closes #26259.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this issue Jul 9, 2023
@humanzz @tmokmss
feat(cloudwatch): allow configuring period on SingleValueWidget (aws#…
c357350 
…26260)

- expose a period prop on `SingleValueWidgetProps`
- use the period prop when rendering `SingleValueWidget`

Closes aws#26259.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@humanzz @bmoffatt
feat(cloudwatch): allow configuring period on SingleValueWidget (aws#…
12ad867 
…26260)

- expose a period prop on `SingleValueWidgetProps`
- use the period prop when rendering `SingleValueWidget`

Closes aws#26259.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): allow configuring period on SingleValueWidget humanzz/aws-cdk
2 participants
@humanzz @khushail