Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(@aws-cdk/aws-gamelift-alpha): Missing properties to support GameLift Server SDK 5+ #27655

Closed
wintersieck opened this issue Oct 23, 2023 · 2 comments · Fixed by #27857
Closed

(@aws-cdk/aws-gamelift-alpha): Missing properties to support GameLift Server SDK 5+ #27655

wintersieck opened this issue Oct 23, 2023 · 2 comments · Fixed by #27857
Labels
@aws-cdk/aws-gamelift Related to Amazon GameLift effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@wintersieck
Copy link

Describe the bug

Two similar issues:

You can't set the ServerSdkVersion property when creating a build, which is mandatory to use SDK 5+ (since the default is 4 something). Here's documentation on the property and the property missing in the CDK documentation.

Similarly, the enum for operating system doesn't allow setting AMAZON_LINUX_2023 as documented here.

Thank you!

Expected Behavior

To be able to set ServerSdkVersion and OperatingSystem.

Current Behavior

You can't set ServerSdkVersion and OperatingSystem.

Reproduction Steps

N/A

Possible Solution

  • Add a serverSdkVersion prop to Build and pass it along when calling CfnBuild.
  • Add AMAZON_LINUX_2023 to the OperatingSystem enum. No logic changes seem to be necessary.

Additional Information/Context

No response

CDK CLI Version

2.101.1

Framework Version

No response

Node.js Version

v20.8.1

OS

Ubuntu (WSL2 on Windows 11)

Language

TypeScript

Language Version

5.2.2

Other information

No response
@wintersieck wintersieck added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2023
@github-actions github-actions bot added the @aws-cdk/aws-gamelift Related to Amazon GameLift label Oct 23, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 24, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@khushail khushail added feature-request A feature should be added or improved. p2 effort/small Small work item – less than a day of effort and removed bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 1, 2023
@khushail
Copy link
Contributor

khushail commented Nov 1, 2023

Thanks @wintersieck for reporting this. Contributions are welcome from the community.
However, if you would like to contribute, feel free to go through Contibuting guide.

@lpizzinidev lpizzinidev mentioned this issue Nov 6, 2023
Merged
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Nov 8, 2023
@mergify
Merge branch 'main' into awsgh-27655
15de967
@mergify mergify bot closed this as completed in #27857 Nov 9, 2023
mergify bot pushed a commit that referenced this issue Nov 9, 2023
@lpizzinidev
feat(gamelift): support Build serverSdkVersion, updated OperatingSyst…
f1bb801 
…em values (#27857)

Some adjustments to `Build` properties:
* Adds support for [`serverSdkVersion`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-gamelift-build.html#cfn-gamelift-build-serversdkversion) attribute
* Updates list of available [`operatingSystem`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-gamelift-build.html#cfn-gamelift-build-operatingsystem) and deprecates Windows Server 2012

Closes #27655.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Nov 13, 2023
@lpizzinidev
feat(gamelift): support Build serverSdkVersion, updated OperatingSyst…
e4c22a2 
…em values (#27857)

Some adjustments to `Build` properties:
* Adds support for [`serverSdkVersion`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-gamelift-build.html#cfn-gamelift-build-serversdkversion) attribute
* Updates list of available [`operatingSystem`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-gamelift-build.html#cfn-gamelift-build-operatingsystem) and deprecates Windows Server 2012

Closes #27655.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-gamelift Related to Amazon GameLift effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gamelift): support Build serverSdkVersion, updated OperatingSystem values lpizzinidev/aws-cdk
2 participants
@wintersieck @khushail