Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-synthetics: support syn-nodejs-puppeteer-9.0 runtime #31271

Closed
2 tasks
sigJoe opened this issue Aug 30, 2024 · 2 comments · Fixed by #31272 · 4 remaining pull requests
Closed
2 tasks

aws-synthetics: support syn-nodejs-puppeteer-9.0 runtime #31271

sigJoe opened this issue Aug 30, 2024 · 2 comments · Fixed by #31272 · 4 remaining pull requests
Assignees
@ashishdhingra
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@sigJoe
Copy link
Contributor

sigJoe commented Aug 30, 2024

Describe the feature

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html confirms that Synthetics runtime "syn-nodejs-puppeteer-9.0" is available.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts only has up to 8.0

Can we support this in CDK please? Thanks.

Use Case

Need to be able to use latest runtimes

Proposed Solution

Update aws-cdk-lib/aws-synthetics/lib/runtime.ts

Other Information

Previous PR for runtime updating: #30851

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.155.0

Environment details (OS name and version, etc.)

n/a
@sigJoe sigJoe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2024
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Aug 30, 2024
@ashishdhingra ashishdhingra self-assigned this Aug 30, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2024
@ashishdhingra ashishdhingra mentioned this issue Aug 30, 2024
Merged
1 task
@ashishdhingra
Copy link
Contributor

Created PR #31272

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Aug 30, 2024
This was referenced Sep 1, 2024
Open
Open
@mergify mergify bot closed this as completed in #31272 Sep 4, 2024
mergify bot pushed a commit that referenced this issue Sep 4, 2024
@ashishdhingra
feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime (#31272)
c1d7782 
### Issue # (if applicable)

Closes #31271.

### Reason for this change
[Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-9.0` is available.

### Description of changes
Added `syn-nodejs-puppeteer-9.0` as supported runtime.

### Description of how you validated changes
N/A

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
pahud pushed a commit to pahud/aws-cdk that referenced this issue Sep 9, 2024
@ashishdhingra @pahud
feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime (aws#…
bd897f7 
…31272)

### Issue # (if applicable)

Closes aws#31271.

### Reason for this change
[Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-9.0` is available.

### Description of changes
Added `syn-nodejs-puppeteer-9.0` as supported runtime.

### Description of how you validated changes
N/A

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@ashishdhingra @xazhao
feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime (aws#…
2bd9e1c 
…31272)

### Issue # (if applicable)

Closes aws#31271.

### Reason for this change
[Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-9.0` is available.

### Description of changes
Added `syn-nodejs-puppeteer-9.0` as supported runtime.

### Description of how you validated changes
N/A

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Sep 12, 2024
@ashishdhingra @GavinZZ
feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime (#31272)
0804023 
### Issue # (if applicable)

Closes #31271.

### Reason for this change
[Runtime versions using Node.js and Puppeteer](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html) confirms that Synthetics runtime `syn-nodejs-puppeteer-9.0` is available.

### Description of changes
Added `syn-nodejs-puppeteer-9.0` as supported runtime.

### Description of how you validated changes
N/A

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashishdhingra ashishdhingra

Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@ashishdhingra @sigJoe