-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(aws-ecs): add container name parameters #13829
chore(aws-ecs): add container name parameters #13829
Conversation
Adds container name property to ContainerDefinitionProps which allows to explicitly set container name. If undefined, this default is still the node id. This is useful if you are using ecs-service-extensions, which allow to create a container, but the container name is hard coded set to 'app'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! Apologies for the delayed response -- really appreciate your contribution! <3
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds container name property to ContainerDefinitionProps which allows to explicitly set container name. If undefined, this default is still the node id. Closes aws#8044 Closes aws#13681 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds container name property to ContainerDefinitionProps which allows to explicitly set container name. If undefined, this default is still the node id. Closes aws#8044 Closes aws#13681 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds container name property to ContainerDefinitionProps which allows
to explicitly set container name. If undefined, this default is still
the node id.
Closes #8044
Closes #13681
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license