fix(core): cannot determine packaging when bundling that produces an archive is skipped #14372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…archive is skipped Bundling is skipped when the bundling directory already exists on disk (cache). If it previously produced a single archive file that has been moved to the staging directory the current logic either failed to determine the correct packaging type or threw because it expected the bundling directory to include a single archive file. Fix it by "touching" the archive file in the bundling directory after it has been moved to the staging directory. Fixes aws#14369
|
|
|
@eladb fyi Not too elegant but it works and I cannot think of another solution... caching is complicated as always... |
otaviomacedo
approved these changes
May 18, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…archive is skipped (aws#14372) Bundling is skipped when the bundling directory already exists on disk (cache). If it previously produced a single archive file that has been moved to the staging directory the current logic either failed to determine the correct packaging type or threw because it expected the bundling directory to include a single archive file. Fix it by "touching" the archive file in the bundling directory after it has been moved to the staging directory. Fixes aws#14369 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling is skipped when the bundling directory already exists on disk
(cache). If it previously produced a single archive file that has been
moved to the staging directory the current logic either failed to
determine the correct packaging type or threw because it expected the
bundling directory to include a single archive file.
Fix it by "touching" the archive file in the bundling directory after it
has been moved to the staging directory.
Fixes #14369
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license