chore: fix NodeJS init templates V2 unit tests for new-style synthesis #14400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our NodeJS init templates for 'app' and 'lib' come with a unit test that verifies the synthesized Stack is empty. However, when we switched to new-style synthesis by default in V2 in aws#14182, that assertion is no longer true - new-style synthesis always adds a Parameter and a Rule to the template. Change the assertion to verify that the `Resources` section is empty instead.
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
changed the title
njlynch
approved these changes
Apr 27, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Apr 29, 2021
Similar to #14400, which fixed the failing JavaScript and TypeScript init template tests. The test fails due to the new Parameter and Rule inserted by the new-style synthesis, which means the stack is no longer empty. Updated the test to check that there are no resources present by default, which frankly feels a bit odd, but at least is consistent. Separately, we need to dive deeper into the fact that `mvn package` can fail when installing the Java template, but `cdk init` still succeeds.
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
Similar to #14400, which fixed the failing JavaScript and TypeScript init template tests. The test fails due to the new Parameter and Rule inserted by the new-style synthesis, which means the stack is no longer empty. Updated the test to check that there are no resources present by default, which frankly feels a bit odd, but at least is consistent. Separately, we need to dive deeper into the fact that `mvn package` can fail when installing the Java template, but `cdk init` still succeeds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@Mergifyio backport master |
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
#14400) Our NodeJS init templates for 'app' and 'lib' come with a unit test that verifies the synthesized Stack is empty. However, when we switched to new-style synthesis by default in V2 in #14182, that assertion is no longer true - new-style synthesis always adds a Parameter and a Rule to the template. Change the assertion to verify that the `Resources` section is empty instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit a1072ae)
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
Similar to #14400, which fixed the failing JavaScript and TypeScript init template tests. The test fails due to the new Parameter and Rule inserted by the new-style synthesis, which means the stack is no longer empty. Updated the test to check that there are no resources present by default, which frankly feels a bit odd, but at least is consistent. Separately, we need to dive deeper into the fact that `mvn package` can fail when installing the Java template, but `cdk init` still succeeds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 13a6ef0)
mergify bot
added a commit
that referenced
this pull request
Apr 29, 2021
…s (backport #14400) (#14450) This is an automatic backport of pull request #14400 done by [Mergify](https://mergify.io). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/ </details>
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…s (backport aws#14400) (aws#14450) This is an automatic backport of pull request aws#14400 done by [Mergify](https://mergify.io). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/ </details>
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…s (backport aws#14400) (aws#14450) This is an automatic backport of pull request aws#14400 done by [Mergify](https://mergify.io). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/ </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our NodeJS init templates for 'app' and 'lib' come with a unit test that verifies the synthesized Stack is empty.
However, when we switched to new-style synthesis by default in V2 in #14182,
that assertion is no longer true -
new-style synthesis always adds a Parameter and a Rule to the template.
Change the assertion to verify that the
Resourcessection is empty instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license