Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v35.0.0 #14411

Merged
merged 7 commits into from
Apr 29, 2021
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Apr 28, 2021

No description provided.

@aws-cdk-automation aws-cdk-automation added pr-linter/exempt-test The PR linter will not require test changes pr/auto-approve Notifies the GH action to auto-approve this PR labels Apr 28, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 28, 2021

The upstream specification is still incorrect.

@gitpod-io
Copy link

gitpod-io bot commented Apr 29, 2021

github-actions[bot]
github-actions bot previously approved these changes Apr 29, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review April 29, 2021 13:50

Pull request has been modified.

@peterwoodworth
Copy link
Contributor

peterwoodworth commented Apr 29, 2021

The patch will be irrelevant soon as they have fixed the spec finally. Current version is 35.1.0, should we go ahead and merge this or wait for the new spec PR to come in?

github-actions[bot]
github-actions bot previously approved these changes Apr 29, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review April 29, 2021 17:36

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Apr 29, 2021
@mergify mergify bot dismissed github-actions[bot]’s stale review April 29, 2021 20:34

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bbed9d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 49e49e7 into master Apr 29, 2021
@mergify mergify bot deleted the bump-cfnspec/v35.0.0 branch April 29, 2021 20:59
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
* feat: cloudformation spec v35.0.0

* Patch incorrect "AWS::AppIntegrations::EventIntegration"

* Suppress linter warning about new property

* Fix casing in StepFunctions DataBrew snapshot test.

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
Co-authored-by: Adam Ruka <adamruka@amazon.com>
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
* feat: cloudformation spec v35.0.0

* Patch incorrect "AWS::AppIntegrations::EventIntegration"

* Suppress linter warning about new property

* Fix casing in StepFunctions DataBrew snapshot test.

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
Co-authored-by: Adam Ruka <adamruka@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/cfnspec pr/auto-approve Notifies the GH action to auto-approve this PR pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants