Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ecs-patterns): adding support for custom HealthCheck while creating QueueProcessingFargateService #18219

Merged
merged 9 commits into from
Jan 25, 2022

Conversation

VarshaVid
Copy link
Contributor

@VarshaVid VarshaVid commented Dec 30, 2021

The QueueProcessingFargateService construct internally creates a service Container with the default healthcheck that cannot currently be overriden by the user. This change allows users to optionally provide a custom healthcheck that can be passed on to the internal ECS container definition.

fixes #15636


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2021

@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@VarshaVid VarshaVid changed the title Adding support for custom HealthCheck while creating QueueProcessingFargateService feat: Adding support for custom HealthCheck while creating QueueProcessingFargateService Dec 30, 2021
@VarshaVid VarshaVid changed the title feat: Adding support for custom HealthCheck while creating QueueProcessingFargateService feat (aws-ecs-patterns): adding support for custom HealthCheck while creating QueueProcessingFargateService Dec 30, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Dec 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@VarshaVid VarshaVid changed the title feat (aws-ecs-patterns): adding support for custom HealthCheck while creating QueueProcessingFargateService feat(aws-ecs-patterns): adding support for custom HealthCheck while creating QueueProcessingFargateService Dec 30, 2021
@peterwoodworth peterwoodworth added the pr-linter/exempt-readme The PR linter will not require README changes label Jan 18, 2022
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this, @VarshaVid! Would you be able to add an example to the README showing how to use this? I saw @peterwoodworth added the label to make this PR exempt from that requirement, but I think it would be nice to have.

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @VarshaVid!

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c1dff06
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0ca81a1 into aws:master Jan 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

LukvonStrom pushed a commit to LukvonStrom/aws-cdk that referenced this pull request Jan 26, 2022
…reating QueueProcessingFargateService (aws#18219)

The `QueueProcessingFargateService` construct internally creates a service Container with the default healthcheck that cannot currently be overriden by the user. This change allows users to optionally provide a custom healthcheck that can be passed on to the internal ECS container definition.

fixes aws#15636

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…reating QueueProcessingFargateService (aws#18219)

The `QueueProcessingFargateService` construct internally creates a service Container with the default healthcheck that cannot currently be overriden by the user. This change allows users to optionally provide a custom healthcheck that can be passed on to the internal ECS container definition.

fixes aws#15636

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
…edFargateService` (#28797)

Closes #28796

Like with other `aws-ecs-pattern` high level constructs, some properties aren't exposed. For `aws_ecs_patterns`.`ApplicationLoadBalancedFargateService` this is `healthCheck` property of the container. 

There are already similar PRs #18219 for other constructs in the `aws_ecs_patterns` lib

*Note*:

I didn't add any test cases since `ApplicationLoadBalancedFargateService` does not seem to have them like the others do. I can maybe come back with another PR to add the test cases.

I didn't update the docs since it's a minor addition. And there is already an example for the `QueueProcessingFargateService` that uses the `healthCheck`, it might be redundant to add the same code example with different constructor name. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
…edFargateService` (#28797)

Closes #28796

Like with other `aws-ecs-pattern` high level constructs, some properties aren't exposed. For `aws_ecs_patterns`.`ApplicationLoadBalancedFargateService` this is `healthCheck` property of the container. 

There are already similar PRs #18219 for other constructs in the `aws_ecs_patterns` lib

*Note*:

I didn't add any test cases since `ApplicationLoadBalancedFargateService` does not seem to have them like the others do. I can maybe come back with another PR to add the test cases.

I didn't update the docs since it's a minor addition. And there is already an example for the `QueueProcessingFargateService` that uses the `healthCheck`, it might be redundant to add the same code example with different constructor name. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-ecs-patterns Related to ecs-patterns library pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-ecs-patterns: Add ability to set healthCheck for QueueProcessingFargateService
4 participants