Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-runner): catch snapshot errors, treat --from-file as command-line #20523

Merged
merged 5 commits into from
May 31, 2022

Commits on May 30, 2022

  1. fix(integ-runner): catch snapshot errors, treat --from-file as comm…

    …and-line
    
    Snapshot errors
    ---------------
    
    The constructor of `IntegSnapshotRunner` calls `loadManifest()`, which
    on my computer happened to fail and stopped the entire test suite
    because this error happened outside the `try/catch` block.
    
    Move it inside the try/catch block, needed a bit of refactoring to
    make sure we could still get at the test name.
    
    `--from-file`
    -------------
    
    Instead of having `--from-file` require a JSON file with its own
    structure, interpret it as a text file which gets treated exactly
    the same as the `[TEST [..]]` arguments on the command line.
    
    This still allows for the `--exclude` behavior by setting that flag
    on the command-line.
    
    Refactoring
    -----------
    
    Moved the logic around determining test names and directories into a
    class (`IntegTest`) which is a convenience class on top of a static data
    record (`IntegTestInfo`). We pass the data record to worker threads.
    rix0rrr committed May 30, 2022
    Configuration menu
    Copy the full SHA
    2007431 View commit details
    Browse the repository at this point in the history
  2. Use relative filename

    rix0rrr committed May 30, 2022
    Configuration menu
    Copy the full SHA
    54e1504 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. chore(integ-runner): print long-running snaphots

    Print snapshot validations that are running for a long time (1 minute).
    This helps diagnose what is stuck, if anything is. On my machine, it
    was tests using Docker because there was some issue with it, and this
    lost me a day.
    
    Also change the test reporting formatting slightly, and catch errors
    during actual test running.
    rix0rrr committed May 31, 2022
    Configuration menu
    Copy the full SHA
    7cb04bf View commit details
    Browse the repository at this point in the history
  2. Remove stray comment

    rix0rrr committed May 31, 2022
    Configuration menu
    Copy the full SHA
    ac45191 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8995f98 View commit details
    Browse the repository at this point in the history