Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aws-cdk-lib imports from ESM modules are broken #23846

Merged
merged 13 commits into from
Jan 26, 2023
Merged

fix: aws-cdk-lib imports from ESM modules are broken #23846

merged 13 commits into from
Jan 26, 2023

Commits on Jan 26, 2023

  1. fix(aws-cdk-lib): imports from ESM modules are broken 

    PR #23813 made imports lazy, but in the resulting code, Nodejs no longer
recognizes the exports when importing `aws-cdk-lib` from an ESM module.

Apply a transformation on the source that makes Nodejs detect the
exports again.
    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    4082d5f View commit details
    Browse the repository at this point in the history

  2. Update lockfile

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    90b5802 View commit details
    Browse the repository at this point in the history

  3. Update test to match actual behavior

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b2d8e3f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'huijbers/esm-lazy-imports' of github.com:aws/aws-cdk in… 

    …to huijbers/esm-lazy-imports
    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    d61fabf View commit details
    Browse the repository at this point in the history

  5. chore(aws-cdk-lib): do not minify index.js

    @mrgrain
    mrgrain committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    7c1fe9d View commit details
    Browse the repository at this point in the history

  6. A mechanism that actually works

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    96c76ee View commit details
    Browse the repository at this point in the history

  7. Merge branch 'huijbers/esm-lazy-imports' of github.com:aws/aws-cdk in… 

    …to huijbers/esm-lazy-imports
    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    cca13b8 View commit details
    Browse the repository at this point in the history

  8. Remove lexer dependency

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    a5b6eba View commit details
    Browse the repository at this point in the history

  9. Unlock yarn.lock changes

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    465fa62 View commit details
    Browse the repository at this point in the history

  10. Undo scripts changes

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    7a31d22 View commit details
    Browse the repository at this point in the history

  11. Update package.json in-place

    @rix0rrr
    rix0rrr committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b22bedd View commit details
    Browse the repository at this point in the history

  12. chore: clean up .npmignore

    @mrgrain
    mrgrain committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    86937e8 View commit details
    Browse the repository at this point in the history

  13. chore: don't output sourcemaps

    @mrgrain
    mrgrain committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0a24bd2 View commit details
    Browse the repository at this point in the history