Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): contributor insight rules for vpc endpoint service #25965

Merged
merged 21 commits into from
Aug 23, 2023
Merged

feat(ec2): contributor insight rules for vpc endpoint service #25965

merged 21 commits into from
Aug 23, 2023

Conversation

khushail
Copy link
Contributor

Closes #25951

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 14, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 14, 2023 00:00
@github-actions github-actions bot added the p2 label Jun 14, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@khushail khushail marked this pull request as draft June 14, 2023 16:27
@khushail khushail changed the title feat(aws-ec2):Add feature to enable contributor insight rules for vpc endpoint service feat(aws-ec2): Add feature to enable contributor insight rules for vpc endpoint service Jun 23, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@khushail khushail changed the title feat(aws-ec2): Add feature to enable contributor insight rules for vpc endpoint service feat(ec2): Add feature to enable contributor insight rules for vpc endpoint service Jul 11, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 11, 2023 20:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@khushail khushail marked this pull request as ready for review July 12, 2023 00:19
pahud
pahud previously requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@pahud pahud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggested changes

packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint-service.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint-service.ts Outdated Show resolved Hide resolved
@khushail @pahud
Update packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint-service.ts
99625c6 
Co-authored-by: Pahud Hsieh <pahudnet@gmail.com>
@mergify mergify bot dismissed pahud’s stale review July 12, 2023 16:02

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 12, 2023
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 27, 2023
@rix0rrr rix0rrr changed the title feat(ec2): Add feature to enable contributor insight rules for vpc endpoint service feat(ec2): contributor insight rules for vpc endpoint service Aug 23, 2023
rix0rrr
rix0rrr previously approved these changes Aug 23, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review August 23, 2023 12:15

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Aug 23, 2023
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review August 23, 2023 12:46

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Aug 23, 2023
View reviewed changes
@mergify mergify bot dismissed rix0rrr’s stale review August 23, 2023 17:05

Pull request has been modified.

mrgrain
mrgrain previously approved these changes Aug 23, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review August 23, 2023 18:15

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f09bf35
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c6a96f0 into aws:main Aug 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@pahud pahud pahud left review comments

@rix0rrr rix0rrr rix0rrr left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khushail @aws-cdk-automation @pahud @mrgrain @rix0rrr @lpizzinidev