Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): Add aws-ecs-1-nvidia to BottlerocketEcsVariant #25978

Closed
wants to merge 3 commits into from

Conversation

automartin5000
Copy link

@automartin5000 automartin5000 commented Jun 14, 2023

Adds aws-ecs-1-nvidia to the BottlerocketEcsVariant enum

Closes #25980

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds `aws-ecs-1-nvidia` to the `BottlerocketEcsVariant` enum
@gitpod-io
Copy link

gitpod-io bot commented Jun 14, 2023

@github-actions github-actions bot added the p2 label Jun 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 14, 2023 12:52
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 14, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@automartin5000 automartin5000 changed the title feat(aws-ecs): Add aws-ecs-1-nvidia to BottlerocketEcsVariant feat(ecs): Add aws-ecs-1-nvidia to BottlerocketEcsVariant Jun 14, 2023
@github-actions github-actions bot added the feature-request A feature should be added or improved. label Jun 14, 2023
@automartin5000
Copy link
Author

automartin5000 commented Jun 14, 2023

Clarification Request: Took a look through the existing Bottlerocket tests and wasn't entirely sure where to go with it. Any suggestions?

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 14, 2023
@corymhall
Copy link
Contributor

Clarification Request: Took a look through the existing Bottlerocket tests and wasn't entirely sure where to go with it. Any suggestions?

Add tests here https://github.com/automartin5000/aws-cdk/blob/patch-1/packages/aws-cdk-lib/aws-ecs/test/cluster.test.ts

And you can add an integ test like this one https://github.com/automartin5000/aws-cdk/blob/patch-1/packages/%40aws-cdk-testing/framework-integ/test/aws-ecs/test/ec2/integ.bottlerocket.ts

@corymhall corymhall removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Jun 27, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5e5f7ab
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 14, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): Add aws-ecs-1-nvidia to BottlerocketEcsVariant
3 participants