Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-staging-synthesizer): reduce the size of DefaultStagingStack template by 5KB #26024

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

kaizencc
Copy link
Contributor

Since DefaultStagingStack is a stack that creates staging resources, it is bound to the CloudFormation limit of 51KB. This means that there is an upper limit on how many ECR repositories (and in turn, unique images) are allowed in the CDK App. In an effort to increase this limit, this PR does the following:

  • Remove path metadata to save ~2KB
  • Remove AWS::CDK::Metadata construct to save ~3KB
  • Insert a dummy UsingDefaultStagingStack construct to the stacks that use the DefaultStagingStack for analytics purposes.

In all, this should decrease the size of the DefaultStagingStack template by ~5KB, or ~10% of the overall size allowed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2023

@github-actions github-actions bot added the p2 label Jun 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2023 23:23
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 16, 2023
@kaizencc kaizencc requested a review from rix0rrr June 19, 2023 20:01
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dff3376
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6858edf into main Jun 20, 2023
@mergify mergify bot deleted the conroy/remove-metadata branch June 20, 2023 21:55
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants