Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-staging-synthesizer): select different bootstrap region #26129

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 27, 2023

Allow selecting the region that was bootstrapped to be distinct from the region that the stack is being deployed to.

Also in this PR, clarify the README.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Allow selecting the region that was bootstrapped to be distinct from the
region that the stack is being deployed to.

Clarify the README a little.
@rix0rrr rix0rrr requested a review from a team June 27, 2023 08:00
@gitpod-io
Copy link

gitpod-io bot commented Jun 27, 2023

@rix0rrr rix0rrr changed the title feat(app-staging-synthesizer): pick bootstrap region feat(app-staging-synthesizer): select different bootstrap region Jun 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 27, 2023 08:00
@github-actions github-actions bot added the p2 label Jun 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 27, 2023 10:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 27, 2023

This allows staging resources to be created when needed next to the CDK App. It has the following
benefits:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah what's your problem with the pretty diagram lol. I thought it was cool

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bdb9f79
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2fec6a4 into main Jun 27, 2023
@mergify mergify bot deleted the huijbers/pick-bootstrap-region branch June 27, 2023 23:46
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

ahmetsoykan pushed a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
…#26129)

Allow selecting the region that was bootstrapped to be distinct from the region that the stack is being deployed to.

Also in this PR, clarify the README.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahmetsoykan added a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
…#26129)

Allow selecting the region that was bootstrapped to be distinct from the region that the stack is being deployed to.

Also in this PR, clarify the README.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
…#26129)

Allow selecting the region that was bootstrapped to be distinct from the region that the stack is being deployed to.

Also in this PR, clarify the README.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants