Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ-runner): add fsevents to optionalDependencies #26151

Merged
merged 2 commits into from
Jun 28, 2023
Merged

chore(integ-runner): add fsevents to optionalDependencies #26151

merged 2 commits into from
Jun 28, 2023

Conversation

corymhall
Copy link
Contributor

This matches the behavior of aws-cdk

When integ-runner is installed on a mac, fsevents will be installed as well.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 28, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 28, 2023 17:15
@github-actions github-actions bot added the p2 label Jun 28, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 998926d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8056e38 into aws:main Jun 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

ahmetsoykan pushed a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
This matches the behavior of [aws-cdk](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/package.json#L31-L35)

When `integ-runner` is installed on a mac, `fsevents` will be installed as well.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahmetsoykan added a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
This matches the behavior of [aws-cdk](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/package.json#L31-L35)

When `integ-runner` is installed on a mac, `fsevents` will be installed as well.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
This matches the behavior of [aws-cdk](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk/package.json#L31-L35)

When `integ-runner` is installed on a mac, `fsevents` will be installed as well.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants