Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): updates logical id validation regex #26174

Closed
wants to merge 34 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
e87a8d5
fix logical id validation
ashwin300a Jun 29, 2023
1402142
docs(cfnspec): update CloudFormation documentation (#26178)
aws-cdk-automation Jun 30, 2023
7036c27
chore(ecs): remove unnecessary js and d.ts files for integration test…
tam0ri Jun 30, 2023
9065b25
fix(rds): monitoring role is not created by default when using reader…
lpizzinidev Jun 30, 2023
1f1b642
fix(ssm): cannot import a ssm parameter with a name containing unreso…
tmokmss Jun 30, 2023
a21b099
chore(lambda): Add missing ARNs for cloudwatch lambda insights (#26153)
orekav Jun 30, 2023
bd86993
feat(iot): add action to start Step Functions State Machine (#26059)
jumic Jun 30, 2023
0a4140e
feat: update alpha modules to sdk v3 (#25895)
MrArnoldPalmer Jun 30, 2023
dcf5352
chore: add spec2cdk tool (#26183)
mrgrain Jun 30, 2023
20d5771
fix logical id validation
ashwin300a Jun 29, 2023
ce0b5a7
Merge branch 'fix-logical-id' of https://github.com/ashwin300/aws-cdk…
ashwin300a Jun 30, 2023
c6d27c3
test(s3): add test cases for buckets and kms keys (#26191)
go-to-k Jul 1, 2023
cf16283
docs(cfnspec): update CloudFormation documentation (#26198)
aws-cdk-automation Jul 3, 2023
141b3df
docs: reduce size of QuickSight generated examples (#26201)
rix0rrr Jul 3, 2023
ae64685
docs(elasticloadbalancing): update readme on internetFacing (#24732)
pattasai Jul 3, 2023
978d028
chore(region-info): register eu-central-2, fix firehose cidr blocks f…
sumupitchayan Jul 3, 2023
bed1ebe
docs(cloudwatch): document cross-account/cross-region alarm limitatio…
rix0rrr Jul 3, 2023
fa3caf3
feat(cfnspec): cloudformation spec v129.0.0 (#26179)
aws-cdk-automation Jul 3, 2023
1f81718
fix(core): tags disappear if CDK app is bundled+minified (#26181)
rix0rrr Jul 3, 2023
db923dd
feat(glue): add ExecutionClass for FLEX (#26203)
go-to-k Jul 3, 2023
9364e94
feat(cli-lib): support bootstrap command (#26205)
AntonioAngelino Jul 3, 2023
06b33d5
fix(sns-subscriptions): cannot add Lambda Subscription when using a L…
mjeanroy Jul 3, 2023
f525e5a
chore(app-staging-synthesizer): tool to test maximum ecr repository a…
kaizencc Jul 3, 2023
bc029fe
feat(codebuild): Support for CodeBuild Image `aws/codebuild/amazonlin…
sktan Jul 3, 2023
a398632
chore: disable v1 branch upkeep (#26218)
RomainMuller Jul 4, 2023
928b64e
docs(cfnspec): update CloudFormation documentation (#26219)
aws-cdk-automation Jul 4, 2023
41cb288
fix(cli-lib): bundle bootstrap template (#26229)
mrgrain Jul 4, 2023
45e2157
docs(cfnspec): update CloudFormation documentation (#26239)
aws-cdk-automation Jul 5, 2023
3a1837a
chore: updates container-definition user jsdoc (#26231)
MichaelLeeHobbs Jul 5, 2023
1a44f69
feat(ecs): enable alarm-based rollbacks (#25840)
bvtujo Jul 5, 2023
3082601
chore: bump spec2cdk packages to 0.0.1 (#26227)
rix0rrr Jul 5, 2023
9837824
fix logical id validation
ashwin300a Jun 29, 2023
251df25
Merge branch 'fix-logical-id' of https://github.com/ashwin300/aws-cdk…
ashwin300 Jul 5, 2023
1b35bfd
add new test to logical id suite
ashwin300 Jul 5, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
18 changes: 0 additions & 18 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,6 @@ updates:
labels:
- "auto-approve"
open-pull-requests-limit: 5

# run same dependabot upgrades on v1-main
- package-ecosystem: "github-actions"
directory: "/"
target-branch: "v1-main"
schedule:
interval: "weekly"
labels:
- "auto-approve"
open-pull-requests-limit: 5
- package-ecosystem: "pip"
directory: "/packages/@aws-cdk/lambda-layer-awscli"
target-branch: "v1-main"
schedule:
interval: "weekly"
labels:
- "auto-approve"
open-pull-requests-limit: 5

# Non-TypeScript init template dependency updates
- package-ecosystem: "pip"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/yarn-upgrade-v1main.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Yarn Upgrade v1-main

on:
schedule:
# Every wednesday at 13:37 UTC
- cron: 37 13 * * 3
workflow_dispatch: {}

jobs:
Expand Down
1 change: 1 addition & 0 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"tools/@aws-cdk/pkglint",
"tools/@aws-cdk/pkgtools",
"tools/@aws-cdk/prlint",
"tools/@aws-cdk/spec2cdk",
"tools/@aws-cdk/yarn-cling",
"scripts/@aws-cdk/script-tests"
],
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@types/node": "18.11.19",
"@types/prettier": "2.6.0",
"@yarnpkg/lockfile": "^1.1.0",
"cdk-generate-synthetic-examples": "^0.1.269",
"cdk-generate-synthetic-examples": "^0.1.287",
"conventional-changelog-cli": "^2.2.2",
"fs-extra": "^9.1.0",
"graceful-fs": "^4.2.11",
Expand Down Expand Up @@ -85,6 +85,7 @@
"tools/@aws-cdk/pkglint",
"tools/@aws-cdk/pkgtools",
"tools/@aws-cdk/prlint",
"tools/@aws-cdk/spec2cdk",
"tools/@aws-cdk/yarn-cling",
"scripts/@aws-cdk/script-tests"
],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "32.0.0",
"files": {
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
"source": {
"path": "amazonlinux25codebuildDefaultTestDeployAssertB1E0750B.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"version":"32.0.0"}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "32.0.0",
"files": {
"172ad225ebadc8dc372534ae917ac11f3878521f5660d84861b5c45a924e7e11": {
"source": {
"path": "codebuild-project-amazonlinux-2-5.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "172ad225ebadc8dc372534ae917ac11f3878521f5660d84861b5c45a924e7e11.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
{
"Resources": {
"MyProjectRole9BBE5233": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "codebuild.amazonaws.com"
}
}
],
"Version": "2012-10-17"
}
}
},
"MyProjectRoleDefaultPolicyB19B7C29": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyDocument": {
"Statement": [
{
"Action": [
"logs:CreateLogGroup",
"logs:CreateLogStream",
"logs:PutLogEvents"
],
"Effect": "Allow",
"Resource": [
{
"Fn::Join": [
"",
[
"arn:",
{
"Ref": "AWS::Partition"
},
":logs:",
{
"Ref": "AWS::Region"
},
":",
{
"Ref": "AWS::AccountId"
},
":log-group:/aws/codebuild/",
{
"Ref": "MyProject39F7B0AE"
},
":*"
]
]
},
{
"Fn::Join": [
"",
[
"arn:",
{
"Ref": "AWS::Partition"
},
":logs:",
{
"Ref": "AWS::Region"
},
":",
{
"Ref": "AWS::AccountId"
},
":log-group:/aws/codebuild/",
{
"Ref": "MyProject39F7B0AE"
}
]
]
}
]
},
{
"Action": [
"codebuild:BatchPutCodeCoverages",
"codebuild:BatchPutTestCases",
"codebuild:CreateReport",
"codebuild:CreateReportGroup",
"codebuild:UpdateReport"
],
"Effect": "Allow",
"Resource": {
"Fn::Join": [
"",
[
"arn:",
{
"Ref": "AWS::Partition"
},
":codebuild:",
{
"Ref": "AWS::Region"
},
":",
{
"Ref": "AWS::AccountId"
},
":report-group/",
{
"Ref": "MyProject39F7B0AE"
},
"-*"
]
]
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "MyProjectRoleDefaultPolicyB19B7C29",
"Roles": [
{
"Ref": "MyProjectRole9BBE5233"
}
]
}
},
"MyProject39F7B0AE": {
"Type": "AWS::CodeBuild::Project",
"Properties": {
"Artifacts": {
"Type": "NO_ARTIFACTS"
},
"Environment": {
"ComputeType": "BUILD_GENERAL1_SMALL",
"Image": "aws/codebuild/amazonlinux2-x86_64-standard:5.0",
"ImagePullCredentialsType": "CODEBUILD",
"PrivilegedMode": false,
"Type": "LINUX_CONTAINER"
},
"ServiceRole": {
"Fn::GetAtt": [
"MyProjectRole9BBE5233",
"Arn"
]
},
"Source": {
"BuildSpec": "{\n \"version\": \"0.2\"\n}",
"Type": "NO_SOURCE"
},
"Cache": {
"Type": "NO_CACHE"
},
"EncryptionKey": "alias/aws/s3"
}
}
},
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"version": "32.0.0",
"testCases": {
"amazon-linux-2-5-codebuild/DefaultTest": {
"stacks": [
"codebuild-project-amazonlinux-2-5"
],
"stackUpdateWorkflow": false,
"assertionStack": "amazon-linux-2-5-codebuild/DefaultTest/DeployAssert",
"assertionStackName": "amazonlinux25codebuildDefaultTestDeployAssertB1E0750B"
}
}
}
Loading