Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(certificatemanager): migrate dns validated certificate handler #27898

Merged
merged 10 commits into from
Nov 17, 2023
Merged

chore(certificatemanager): migrate dns validated certificate handler #27898

merged 10 commits into from
Nov 17, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Nov 8, 2023

This PR moves the dns validated certificate handler from aws-cdk-lib to our new centralized location for custom resource handlers in the @aws-cdk package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@colifran
migrated dns validated vertificate handler
fe34460 
Signed-off-by: Francis <colifran@amazon.com>
@colifran
snaps
c1617c3 
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team November 8, 2023 18:50
@github-actions github-actions bot added the p2 label Nov 8, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 8, 2023
@colifran
dev dependencies
76c9955 
Signed-off-by: Francis <colifran@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 8, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Nov 10, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 84a78b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c66e197 into main Nov 17, 2023
12 checks passed
@mergify mergify bot deleted the colifran/migrate-dns-validated-cert branch November 17, 2023 21:26
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

Assignees

@vinayak-kukreja vinayak-kukreja

Labels
contribution/core This is a PR that came from AWS. handler-migration p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colifran @aws-cdk-automation @vinayak-kukreja