Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler): typo in metricSentToDLQ... methods #28307

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

sakurai-ryo
Copy link
Contributor

@sakurai-ryo sakurai-ryo commented Dec 8, 2023

This PR includes breaking changes to the aws-scheduler-alpha module.

Description

This PR introduces breaking changes by correcting typos in the method names of the Schedule and Group constructs.
Specifically, the method name metricSentToDLQTrunacted has been changed to metricSentToDLQTruncated, and metricAllSentToDLQTrunacted has been changed to metricAllSentToDLQTruncated.
https://docs.aws.amazon.com/scheduler/latest/UserGuide/monitoring-cloudwatch.html

BREAKING CHANGE: The typos in the Schedule and Group construct method names have been fixed, changing metricSentToDLQTrunacted to metricSentToDLQTruncated and metricAllSentToDLQTrunacted to metricAllSentToDLQTruncated.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Dec 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 8, 2023 17:45
@github-actions github-actions bot added the p2 label Dec 8, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sakurai-ryo
Copy link
Contributor Author

Exemption Request: In addition to the absence of existing tests, I think there is no need to add tests for this change.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Dec 8, 2023
@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Dec 8, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol whoops. Wouldn't it be funny if we changed the name to metricSentToDLQTrunc instead :)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 8, 2023 18:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kaizencc kaizencc changed the title fix(scheduler): fix the method name of Schedule and Group construct fix(scheduler): typo in metricSentToDLQ... methods Dec 8, 2023
@github-actions github-actions bot added the p2 label Dec 8, 2023
@sakurai-ryo
Copy link
Contributor Author

sakurai-ryo commented Dec 8, 2023

@kaizencc
Thanks for the review!
The build failed with the following unseen error, do you know the cause?

Installing from NPM...
npm WARN exec The following package was not found and will be installed: npm@7.24.2
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/compat-check/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/compat-check/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2023-12-08T18_12_59_070Z-debug.log

It failed at this part of the script.

(cd $tmpdir && npx npm@^7.0.0 install --prefix $tmpdir $install_versions)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f57a795
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8b91e10 into aws:main Dec 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants