Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apigateway): fix typo in a doc and a private method for lambda authorizers #28411

Merged
merged 3 commits into from
Dec 18, 2023
Merged

chore(apigateway): fix typo in a doc and a private method for lambda authorizers #28411

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
089b277
chore(apigateway): fix typo in a doc and a private method for lambda …
go-to-k Dec 18, 2023
a74eebf
Merge branch 'main' into chore/api-gateway-typo
go-to-k Dec 18, 2023
00876fe
Apply suggestions from code review
kaizencc Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/aws-cdk-lib/aws-apigateway/lib/authorizers/lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ abstract class LambdaAuthorizer extends Authorizer implements IAuthorizer {
*/
protected setupPermissions() {
if (!this.role) {
this.addDefaultPermisionRole();
this.addDefaultPermissionRole();
} else if (iam.Role.isRole(this.role)) {
this.addLambdaInvokePermission(this.role);
}
Expand All @@ -132,15 +132,15 @@ abstract class LambdaAuthorizer extends Authorizer implements IAuthorizer {
/**
* Add Default Permission Role for handler
*/
private addDefaultPermisionRole() :void {
private addDefaultPermissionRole() :void {
kaizencc marked this conversation as resolved.
Show resolved Hide resolved
this.handler.addPermission(`${Names.uniqueId(this)}:Permissions`, {
principal: new iam.ServicePrincipal('apigateway.amazonaws.com'),
sourceArn: this.authorizerArn,
});
}

/**
* Add Lambda Invoke Permission for LambdaAurhorizer's role
* Add Lambda Invoke Permission for Lambda Authorizer's role
*/
private addLambdaInvokePermission(role: iam.Role) :void {
kaizencc marked this conversation as resolved.
Show resolved Hide resolved
role.attachInlinePolicy(new iam.Policy(this, 'authorizerInvokePolicy', {
Expand Down