Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): Add log group property to RDS instance and RDS cluster #28676

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jan 11, 2024

There isn't an easy way to get the new created log group of an DatabaseInstance if the DatabaseInstance has the cloudwatchLogsExport property set. Right now users would have to manual figure out the log group name by constructing /aws/rds/instance/${this.databaseInstance.instanceIdentifier}/postgresql. Same applies to RDS cluster resource.

This is also dangerous as it relies on the naming convention unmodified. It would break the application if the naming convention was somehow changed.

Add a new property cloudwatchLogGroups to RDS instance and cluster.

Closes ##20358.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 11, 2024 23:03
@github-actions github-actions bot added the p2 label Jan 11, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ changed the title feat(aws-rds): Add log group property to RDS instance and RDS cluster feat(rds): Add log group property to RDS instance and RDS cluster Jan 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 11, 2024 23:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ force-pushed the yuanhaoz/rds_instance_log_group branch from 367fd3f to 8e090c5 Compare January 11, 2024 23:13
@GavinZZ GavinZZ force-pushed the yuanhaoz/rds_instance_log_group branch from 8e090c5 to 7375086 Compare January 11, 2024 23:15
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 12, 2024
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor doc changes. Should we also create an integ test for RDS cluster?

packages/aws-cdk-lib/aws-rds/lib/cluster.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-rds/lib/instance.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 13, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 659d878
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants