Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecs): typo in ec2-service.ts #29030

Merged
merged 2 commits into from
Feb 8, 2024
Merged

chore(ecs): typo in ec2-service.ts #29030

merged 2 commits into from
Feb 8, 2024

Conversation

DaxServer
Copy link
Contributor

@DaxServer DaxServer commented Feb 8, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 8, 2024 13:55
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Feb 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc changed the title chore: Update typo in ec2-service.ts chore(ecs): typo in ec2-service.ts Feb 8, 2024
@kaizencc
Copy link
Contributor

kaizencc commented Feb 8, 2024

uh oh... why does it think there are breaking changes... I'm looking into it

@kaizencc
Copy link
Contributor

kaizencc commented Feb 8, 2024

Oh my... in the comment section of the PR description is

<!--Does this PR includes breaking changes? If it does, list them here in the following format (notice how multiple breaking changes should be formatted):

BREAKING CHANGE: Description of the breaking change, the previous behaviour, and the new behaviour.

  • module-name: Another breaking change
  • module-name: Yet another breaking change
-->

Thats whats flagging this

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 8, 2024 16:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Feb 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bd97d04
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1027d87 into aws:main Feb 8, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Feb 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@DaxServer DaxServer deleted the patch-1 branch February 8, 2024 17:13
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants