Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoscaling): add support for InstanceRefresh suspended process #29113

Merged
merged 5 commits into from
Mar 7, 2024
Merged

feat(autoscaling): add support for InstanceRefresh suspended process #29113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7702b2
Add InstanceRefresh suspended process and add it to default list set …
mulmar-aws Feb 14, 2024
de8c8f2
Fix trailing comma
Feb 14, 2024
afcfa37
Fix another dangling comma and add integration test
Feb 16, 2024
c7184d2
Merge branch 'main' into instance-refresh-suspended-process
xazhao Feb 29, 2024
fd14634
Merge branch 'main' into instance-refresh-suspended-process
xazhao Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,12 +2135,13 @@ export enum ScalingProcess {
ALARM_NOTIFICATION = 'AlarmNotification',
SCHEDULED_ACTIONS = 'ScheduledActions',
ADD_TO_LOAD_BALANCER = 'AddToLoadBalancer',
INSTANCE_REFRESH = 'InstanceRefresh',
}

// Recommended list of processes to suspend from here:
// https://aws.amazon.com/premiumsupport/knowledge-center/auto-scaling-group-rolling-updates/
const DEFAULT_SUSPEND_PROCESSES = [ScalingProcess.HEALTH_CHECK, ScalingProcess.REPLACE_UNHEALTHY, ScalingProcess.AZ_REBALANCE,
ScalingProcess.ALARM_NOTIFICATION, ScalingProcess.SCHEDULED_ACTIONS];
ScalingProcess.ALARM_NOTIFICATION, ScalingProcess.SCHEDULED_ACTIONS, ScalingProcess.INSTANCE_REFRESH];

/**
* EC2 Heath check options
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-autoscaling/test/auto-scaling-group.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ describe('auto scaling group', () => {
'MinSuccessfulInstancesPercent': 50,
'WaitOnResourceSignals': true,
'PauseTime': 'PT5M45S',
'SuspendProcesses': ['HealthCheck', 'ReplaceUnhealthy', 'AZRebalance', 'AlarmNotification', 'ScheduledActions'],
'SuspendProcesses': ['HealthCheck', 'ReplaceUnhealthy', 'AZRebalance', 'AlarmNotification', 'ScheduledActions', 'InstanceRefresh'],
},
},
});
Expand Down
1 change: 1 addition & 0 deletions packages/aws-cdk-lib/aws-autoscaling/test/scheduled-action.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ describeDeprecated('scheduled action', () => {
'AZRebalance',
'AlarmNotification',
'ScheduledActions',
'InstanceRefresh'
xazhao marked this conversation as resolved.
Show resolved Hide resolved
],
},
AutoScalingScheduledAction: {
Expand Down
Loading