Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(step-function-tasks): add comment that aws-sdk integration pattern is not impacted by sdk upgrade #29795

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

vinayak-kukreja
Copy link
Contributor

Reason for this change

For upgrading sdkv2 to sdkv3, I have confirmed that the pattern used by step function task is not impacted by the migration and will remain the same.

Adding a comment to add historical context for anyone revisiting this package for another sdk upgrade.

Description of changes

Just added comments. No code changes.

Description of how you validated changes

No tests added for comments

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ern is not impacted by sdk upgrade

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@github-actions github-actions bot added the p2 label Apr 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 11, 2024 16:50
@vinayak-kukreja vinayak-kukreja changed the title chore(step-function-tasks): add comment that aws-sdk integration pattern is not impacted by sdk upgrade chore(step-function-tasks): add comment that aws-sdk integration pattern is not impacted by sdk upgrade Apr 11, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 11, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 921b571
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b0e0353 into main Apr 11, 2024
27 checks passed
@mergify mergify bot deleted the vkukreja/inform branch April 11, 2024 17:18
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants