Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli-testing): add a retry for test #29908

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

One of our tests can remove customPermissionsBoundary creates a policy using createPolicy. Change to IAM policies/roles use eventual consistency. So, while the changes will show up right away if we were to call an API to describe that policy/role, the updates may not have actually propagated to all regions yet. This is likely the cause of the intermittent test failures for this test.

This change adds the eventually block and uses it to retry initial creation of this stack in the case that the policy changes have not made it to the relevant region just yet.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

TheRealAmazonKendra and others added 4 commits April 17, 2024 13:27
One of our tests can remove customPermissionsBoundary creates a policy using createPolicy.
Change to IAM policies/roles use eventual consistency. So, while the changes will show up right
away if we were to call an API to describe that policy/role, the updates may not have actually propagated
to all regions yet. This is likely the cause of the intermittant test failures for this test.

This change adds the eventually block and uses it to retry initial creation of this stack in the case
that the policy changes have not made it to the relevant region just yet.
@github-actions github-actions bot added the p2 label Apr 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 19, 2024 20:57
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 19, 2024
@aws-cdk-automation aws-cdk-automation added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 19, 2024
Copy link
Contributor

mergify bot commented Apr 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aefb558
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9eb21bd into main Apr 19, 2024
11 of 12 checks passed
@mergify mergify bot deleted the TheRealAmazonKendra/eventually branch April 19, 2024 22:53
Copy link
Contributor

mergify bot commented Apr 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants