Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" #30590

Merged
merged 1 commit into from
Jun 19, 2024
Merged

revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" #30590

merged 1 commit into from
Jun 19, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

Reverts #30394

@github-actions github-actions bot added the p2 label Jun 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 19, 2024 17:41
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 19, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@TheRealAmazonKendra TheRealAmazonKendra added the pr/do-not-merge This PR should not be merged at this time. label Jun 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cd07d30
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra TheRealAmazonKendra changed the title Revert "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" revert "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" Jun 19, 2024
@TheRealAmazonKendra TheRealAmazonKendra removed the pr/do-not-merge This PR should not be merged at this time. label Jun 19, 2024
@TheRealAmazonKendra TheRealAmazonKendra changed the title revert "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects provider lambda" Jun 19, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 19, 2024 22:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e02578f into main Jun 19, 2024
35 of 40 checks passed
@mergify mergify bot deleted the revert-30394-bucket-auto-delete-objects-logging branch June 19, 2024 22:13
sarangarav pushed a commit to sarangarav/aws-cdk that referenced this pull request Jun 21, 2024
@TheRealAmazonKendra
revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDelet…
cc27aba 
…eObjects provider lambda" (aws#30590)

Reverts aws#30394
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
@TheRealAmazonKendra @mazyu36
revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDelet…
0d6f897 
…eObjects provider lambda" (aws#30590)

Reverts aws#30394
This was referenced Jun 24, 2024
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@comcalvi comcalvi comcalvi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheRealAmazonKendra @aws-cdk-automation @GavinZZ @comcalvi