chore(CLI-integ-tests): cli integ tests cannot use local CDK framework #31131
Conversation
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
comcalvi
added
the
pr-linter/cli-integ-tested
| captureStderr: false, | ||
| cwd: root, | ||
| show: 'error', | ||
| })); | ||
| })).data; | ||
| const output: YarnWorkspacesOutput = JSON.parse(outputDataString); |
There was a problem hiding this comment.
Why do we need to parse the shell output again?
There was a problem hiding this comment.
we first need to parse the output of yarn workspaces, which includes a data object. That data object is an escaped JSON string, which needs to be parsed again.
| @@ -96,7 +97,7 @@ async function findYarnPackages(root: string): Promise<Record<string, string>> { | |||
| * Find the root directory of the repo from the current directory | |||
| */ | |||
| export async function autoFindRoot() { | |||
| const found = await findUp('release.json'); | |||
| const found = findUp('release.json'); | |||
There was a problem hiding this comment.
Odd that this was ever awaited. Looking in the findUp function, I am not seeing async calls, but is there any chance this await is necessary?
There was a problem hiding this comment.
TS compiler said it's not needed, so I removed it. It doesn't return a promise, so there's no need to await anything here.
|
Yep, it skips installing the CDK and uses the local version. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
The cli integration tests cannot use your local version of
aws-cdk-lib. This can be verified by making yourStackconstruct throw an error upon creation, and watching no CLI integration tests fail, even with-a.Description of changes
Fixed the CLI integration test framework to correctly link the local packages, like it used to.
Description of how you validated changes
Manual testing. This isn't something we can add automated tests for.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license