chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block #31206
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
paulhcsun
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| @@ -252,6 +252,9 @@ | |||
| "ca-central-1": { | |||
| "FirehoseCidrBlock": "35.183.92.128/27" | |||
| }, | |||
| "ca-west-1": { | |||
| "FirehoseCidrBlock": "40.176.98.192/27/27" | |||
There was a problem hiding this comment.
Should be 40.176.98.192/27. There is an extra /27 at the end.
There was a problem hiding this comment.
Not sure why but this keeps getting automatically updated with the extra /27 and overriding my changes.
There was a problem hiding this comment.
Realized I was not updating the value in the correct place. It should be fixed now.
|
oops one more integ test snapshot to update |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@Mergifyio update |
☑️ Nothing to do
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #29874
Description of changes
Add missing CIDR block for
ca-west-1+ update snapshots.CIDRs pulled from here.
Description of how you validated changes
integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license