-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update s3 bucket physical names to use amazon owned s3 buckets #31576
docs: update s3 bucket physical names to use amazon owned s3 buckets #31576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get the build to succeed you are going to need to run some of the integ tests. you should be able to add --dry-run
to the integ command so that you don't actually deploy the test
# Conflicts: # packages/aws-cdk/README.md
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
By using Amazon owned s3 bucket physical names, we remove the possibility of documenting customer owned buckets in our examples.
Description of changes
Change physical S3 bucket names such as
my-bucket
to Amazon owned ones such asamzn-s3-demo-bucket
.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license