Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): isTaggable function can return undefined instead of false #31600

Merged
merged 6 commits into from
Oct 2, 2024
Merged

fix(core): isTaggable function can return undefined instead of false #31600

merged 6 commits into from
Oct 2, 2024
+38 −1

Commits on Sep 30, 2024

  1. fix(core): isTaggable function returns undefined instead of false 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    969b5af View commit details
    Browse the repository at this point in the history

  2. WIP 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dcdfee8 View commit details
    Browse the repository at this point in the history

  3. fix import order 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    25efcbd View commit details
    Browse the repository at this point in the history

  4. fix import order x2 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ff22c35 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix return statement to explicitly handle null and undefined cases 

    Signed-off-by: Sumu <sumughan@amazon.com>
    @sumupitchayan
    sumupitchayan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    91ca660 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'main' into sumughan/fix-is-taggable-function

    @sumupitchayan
    sumupitchayan authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d1c727b View commit details
    Browse the repository at this point in the history