Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Backport CHANGELOG entries from v1.16.2 #4980

Merged
merged 1 commit into from
Nov 12, 2019
Merged

chore: Backport CHANGELOG entries from v1.16.2 #4980

merged 1 commit into from
Nov 12, 2019

Conversation

RomainMuller
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 12, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 6fa4713 into master Nov 12, 2019
@mergify mergify bot deleted the rmuller/merge-v1.16.2 branch November 12, 2019 14:38
arhea pushed a commit to arhea/aws-cdk that referenced this pull request Nov 19, 2019
Merge branch '4955-eks-patterns' of github.com:arhea/aws-cdk into 495…
0e5ec13 
…5-eks-patterns

* '4955-eks-patterns' of github.com:arhea/aws-cdk:
  feat(cli): adding new option to `cdk deploy` to indicate whether ChangeSet should be executed (aws#4852)
  chore: move semantic.yaml to .github/
  fix(core): unable to find stack by name using the cli in legacy mode (aws#4998)
  fix(ecs-patterns): Fix issue related to protocol being passed to target group (aws#4988)
  chore: Backport CHANGELOG entries from v1.16.2 (aws#4980)
  feat(custom-resources): python handler skelaton in readme (aws#4977)
  fix(logs): cannot use same Lambda for multiple SubscriptionFilters (aws#4975)
  release: v1.16.1 (aws#4965)
  chore: resolve inaccurate label line in depbot config (aws#4729)
  chore(deps): bump aws-sdk from 2.568.0 to 2.569.0 (aws#4958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainMuller @aws-cdk-automation @eladb