Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): unable to find stack by name using the cli in legacy mode #4998

Merged
merged 1 commit into from
Nov 13, 2019
Merged

fix(core): unable to find stack by name using the cli in legacy mode #4998

merged 1 commit into from
Nov 13, 2019
+62 −26

Commits on Nov 13, 2019

  1. fix(core): unable to find stack by name using the cli in legacy mode 

    Legacy mode for #4895 still used the uniquely generated id instead of the stack name as the artifact ID in the cloud assembly. The implications were that even if users were not opted-in to the new behavior (through the feature flag), they could not use the stack name in the CLI because the stack artifact ID was still new.

This fix ensures that if the feature flag is not enabled, the artifact ID itself uses the stack name, hence allowing users to query by stack name as long as they are not opted in to the new behavior.

Fixes #4997
    Elad Ben-Israel committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    c231da9 View commit details
    Browse the repository at this point in the history