-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 1.38.0 #7861
Merged
Merged
chore(release): 1.38.0 #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge release/1.37.0 to master
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.668.0 to 2.669.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.668.0...v2.669.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
A helper for implementing simple node.js-based custom resource providers. This is a simpler framework from what is offered `@aws-cdk/custom-resources.Provider`, designed to enable implementing custom resources with minimal dependencies. To that end, this helper uses `CfnResource` to define the AWS Lambda function and the low-level asset mechanism in order to create an asset for the lambda bundle. Comparing to the advanced provider framework, this provider DOES NOT support: - Arbitrary lambda function handlers, only node.js function. - Asynchronous "isComplete" waiters (limited to 15min lambda timeout). Since `cdk-integ` depends on `cdk` which depends on `@aws-cdk/core` (as a "dev dependency"), I've added the integ test for this in @aws-cdk/aws-cloudformation. This probably belongs to some other module (`@aws-cdk/core-tests`?). This is a precursor for implementing support for Open ID connect providers in the AWS IAM module, which is a very low-level module in our stack.
…t controller. Fixes #6245.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
some of the syntax is out of date or incorrect Closes #7801
The automatic parameter reuse which was introduced in #7041 has been causing issues for some people who use Default Values to classify between CI/CD deployments and CLI deployments (value supplied=CI/CD, value default=CLI). Introduce a switch to turn it off.
… root directory name (#7719) When creating an asset from a directory with certain exclude options, the fingerprint does not change even if the files change. If a fingerprint is calculated over a directory with exclude options `[ '**', '!file' ]`, the code never descends into the directory. This commit skips the exclude check for the root directory, to correctly handle negated expressions in the exclude options. fixes #7718
basically gpus were not being assigned to JobDefinitions because while the props accepted gpuCount, it was never passed down to the container properties and ultimately the resource requirements section of the Cfn resource. This PR will fix this issue and actually allow Gpus to be set using the JobDefinition resource.
We inherit a transitive dependency on diff@1.4.0 which has been flagged as having a security vulnerability (all versions <3.5.0 are vulnerable). This dependency is coming in via nodeunit → node-tap → tap-mocha-reporter → diff. Only the absolute latest release, 5.0.1 as of this commit, of tap-mocha-reporter has upgraded to use diff@4.0.1. Hence, forcing resolution to use tap-mocha-reporter@5.0.1 so we get rid of the old version of diff. The longer term plan is to move away from nodeunit (which is deprecated) and use jest. This would prune out the offending dependency subtree. Internal ref: t.corp/V198831592
Added `blockDevices?` property to `BastionHostLinuxProps` to allow full EBS device configuration so that customers can use it for use-cases like to encrypt an EBS volume for BastionHostLinux Fixes #6945
Allows specifying a position for the legend for a GraphWidget. If omitted, defaults to the bottom of the graph. fixes #3625
Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.669.0 to 2.670.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.669.0...v2.670.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 25.4.0 to 25.5.0. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v25.4.0...v25.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Noah Litov <noahlitov@gmail.com>
…ersion (#7830) Cluster version updates fail with `vendor response doesn't contain <ATTRIBUTE>` errors due to the fact that since #7526 the provider does not respond to `isComplete` with the `Data` field with resource attributes. The fix is that once the update is complete, we simply delegate to `isActive` which queries the cluster and returns the attributes. Fixes #7794
Added empty array check for keyActions. This will make sure that `grantDelete` will not create malformed policy when used with `KMS` key. Added a new integ test to check CloudFormation will not error out during the deployment. Fixes #4380
This adds support for CodeBuild's test reports feature. It includes a new Layer 2 class, ReportGroup. The default project's IAM role has been augmented with permissions to create and use test result groups whose names begin with the project's name (as that is what the default report group created when putting a simple name in the 'reports' buildspec section is called). There is a new boolean property when creating the project, addCreateReportGroupPermissions, that can be used to turn off this behavor. Fixes #7367
Custom State which enables the capability to provide Amazon States Language (ASL) JSON as an escape hatch. Useful when there are capabilities that are offered through Step Functions such as service integrations, and state properties but there isn't support through the CDK yet. It enables the usage of all service integrations we don't currently support.
) For tasks that use the Fargate launch type, it is only supported to inject the full contents of a secret as an environment variable. Specifying a specific JSON key or version is not supported at this time. Also clean up/refactor a bit. See https://docs.aws.amazon.com/AmazonECS/latest/userguide/specifying-sensitive-data-secrets.html#secrets-considerations Closes #7272
Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.0. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.670.0 to 2.671.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.670.0...v2.671.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
It was reverted (#7738).
This PR re-enables the cli regression tests. **Why were they disabled?** We were booting up verdaccio without configuring an `npm` uplink for our own packages. This was ok because we used to only test locally built packages, both of the CLI and the framework. The regression tests introduced another combination where we test the locally built CLI, against the latest published packages of the framework. But since we didn't used to have an uplink for our own packages. the installation would fail. **Why will it work now?** Two reasons: 1. We now do have an `npm` uplink for verdaccio. 2. Don't start a long running verdaccio instance for tests that use the latest published version. In addition, this PR exposes various execution permutations via the `package.json` instead of hiding them in scripts. This brings it back to how it was originally.
There was another protocol of implicit "props" queries in the cloud assembly, which is the "missing context queries" protocol. Move it into the cloud-assembly-schema package so we can properly version updates to it. There was still some additional stuff in the protocol around constants and return types. Did not move those yet since I'm not sure how they fit into the schema. Taking it one step at a time.
The [`StackWithNestedStackUsingParameters`](https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/test/integ/cli/app/nested-stack.js#L25) in our integ test was for some reason passing a hardcoded parameter value to the nested stack instead of using the parameter value from the parent stack. In addition to not actually testing that parameters are passable between the parent and the child, it caused a collision with parallel tests because the topic name is provided was not unique. This PR simply passes the parent stack parameter to the nested stack, the value of the parent stack param is already unique because it [prepends](https://github.com/aws/aws-cdk/blob/master/packages/aws-cdk/test/integ/cli/test-cdk-deploy-nested-stack-with-parameters.sh#L11) the stack prefix. In addition, many tests were using parameters like so: ```typescript new sns.Topic(this, 'TopicParameter', { topicName: new cdk.CfnParameter(this, 'TopicNameParam') }); ``` instead of: ```typescript new sns.Topic(this, 'TopicParameter', { topicName: new cdk.CfnParameter(this, 'TopicNameParam').valueAsString }); ``` The `topicName` property expects a `string`, not a `CfnParameter`. Since our tests are in `javascript`, it "compiled". But migrating this to `typescript` would actually result in a proper compilation error. Strangely enough, both of these synthesize to the same thing: ```yaml Parameters: MyTopicParam: Type: String Resources: MyTopic86869434: Type: AWS::SNS::Topic Properties: TopicName: Ref: MyTopicParam ``` This is because `CfnParameter` resolves to its `value` getter: ```typescript public resolve(_context: IResolveContext): any { return this.value; } ```
…ice (#7850) Co-authored-by: robertd <robert.djurasaj@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Changed inline documentation for `encryptionMasterKey` to reflect that if `encryptionMasterKey` is provided, `encryption` type is always KMS. Closes #7694
More tests that don't use unique physical resource names
This change adds a new package whose sole purpose is to illustrate the many concepts and patterns used in the CDK Construct Library. The idea is it would serve as the jumping-off point for contributions to the main CDK repo, and also creating independent construct libraries.
A Secret would fail to create when using a customer managed KMS key with the Secret. This commit adds the required KMS permissions to the key to allow the SecretsManager service to use the key.
Upgrade JSII version to 1.5.0
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.671.0 to 2.672.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.671.0...v2.672.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
NetaNir
added
the
pr/no-squash
This PR should be merged instead of squash-merging it
label
May 8, 2020
shivlaks
approved these changes
May 8, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see CHANGELOG