Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.42.0 #8229

Merged
merged 36 commits into from
May 27, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0a3785b
feat(cloudtrail): user specified log group (#8079)
May 21, 2020
903701a
chore(cloudwatch-actions): clear linter exclusions (#8046)
shivlaks May 21, 2020
395c07c
fix(events): cannot use the same target account for 2 cross-account e…
skinny85 May 21, 2020
3d30ffa
feat(elbv2): Supports new types of listener rule conditions (#7848)
karupanerura May 21, 2020
21f9f76
chore(cli): simpler error message on cloud assembly version mismatch …
iliapolo May 21, 2020
01fa408
chore: add test deploying old-style synthesis to new-style bootstrap …
rix0rrr May 21, 2020
ed43305
chore(release): 1.41.0 (#8130)
May 21, 2020
60814b7
chore: add node version to issue template (#8121)
shivlaks May 21, 2020
35a01a0
feat(eks): improve security using IRSA conditions (#8084)
vlesierse May 21, 2020
8610889
fix(aws-eks): kubectlEnabled: false conflicts with addNodegroup (#8119)
pahud May 22, 2020
8b19453
docs(lambda): document adding execution permissions to provided IAM r…
flemjame-at-amazon May 22, 2020
9899c76
chore(stepfunctions): add missing tests (#8147)
shivlaks May 22, 2020
a721e67
feat(stepfunctions-tasks): task for starting a job run in AWS Glue (#…
shivlaks May 22, 2020
86eac6a
feat(stepfunctions): support paths in Pass state (#8070)
shivlaks May 24, 2020
1ecc3f8
chore: clear 'breaking changes' history (#8128)
rix0rrr May 25, 2020
7d0c173
chore(deps): bump @typescript-eslint/eslint-plugin from 2.34.0 to 3.0…
dependabot-preview[bot] May 25, 2020
edbeff5
chore: fix tsc-3.9 issues ahead of upgrade (#8182)
RomainMuller May 25, 2020
af2ea60
fix(cli): paper cuts (#8164)
rix0rrr May 25, 2020
575f1db
feat(codepipeline): use a special bootstrapless synthesizer for cross…
skinny85 May 25, 2020
0393528
fix(dynamodb): the maximum number of nonKeyAttributes is 100, not 20 …
RomainMuller May 25, 2020
8e473e5
chore: fix build (#8187)
rix0rrr May 25, 2020
032be69
chore(deps): bump uuid from 8.0.0 to 8.1.0 (#8190)
dependabot-preview[bot] May 25, 2020
106c0af
chore(core): fix grammar in comments (#8191)
HaileyGu May 25, 2020
c4b25ba
chore(cognito): fix typo (#8194)
Fallenstedt May 25, 2020
44e4d66
chore(backup): use interface instead of concrete class for resources …
jogold May 26, 2020
995088a
feat(codeguruprofiler): ProfilingGroup (#7895)
SeekerWing May 26, 2020
f26063f
docs(rds): invalid master username (#5076)
spg May 26, 2020
524440c
fix(eks): unable to add multiple service accounts (#8122)
vlesierse May 26, 2020
fab09b1
chore(aws-eks): update README with correct service account syntax (#8…
pahud May 26, 2020
c2e9c77
docs: add note on global npm installs, change OpenJDK URL (#8208)
ericzbeard May 26, 2020
b4adf07
chore(stepfunctions): add tests for state transition metrics (#8179)
shivlaks May 26, 2020
04490b1
fix(lambda-nodejs): build fails on Windows (#8140)
jogold May 26, 2020
99e7330
feat(cfnspec): cloudformation spec v14.4.0 (#8195)
aws-cdk-automation May 27, 2020
0028778
chore(cloudtrail): better typed event selector apis (#8097)
May 27, 2020
facf3a2
chore(release): 1.42.0
May 27, 2020
96a0893
Merge branch 'release' into bump/1.42.0
iliapolo May 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(cli): simpler error message on cloud assembly version mismatch (#…
…8129)

The error message we currently print when a user has a CLI version that is not compatible with the framework is:

```console
Cloud assembly schema version mismatch: Maximum schema version supported is 1.33.0, 
but found 2.0.0. Please upgrade your CLI in order to interact with this app.
```

This is pretty cryptic, we shouldn't be starting the message with `Cloud Assembly`, as most users aren't really versed in, or even aware of it. In addition, the versions mentioned here are confusing and might give the impression we are asking users to upgrade to CLI version `2.0.0`. 

This PR simplifies the message to:

```
❯ cdk synth                                                                                                                                                                                                                                                                                     [14:27:15]
The CLI version you are using does not support your application version. Please upgrade the CLI to the latest version.
(Your application requires a CLI that supports a cloud assembly of version '2.0.0' or above.)
```

It clearly states what wrongs (CLI version incompatible) and how to fix (upgrade) right of the bat. 
The tail of the message is an attempt to explain why the CLI does not support the framework. 

Fixes #7901

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
iliapolo authored May 21, 2020
commit 21f9f768e8be9114b09a370761015002771d43f6
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/api/cxapp/exec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export async function execProgram(aws: SdkProvider, config: Configuration): Prom
if (error.message.includes(cxschema.VERSION_MISMATCH)) {
// this means the CLI version is too old.
// we instruct the user to upgrade.
throw new Error(`${error.message}.\nPlease upgrade your CLI in order to interact with this app.`);
throw new Error(`This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version.\n(${error.message})`);
}
throw error;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-cdk/test/api/exec.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ test('cli throws when manifest version > schema version', async () => {
mockVersionNumber.restore();
}

const expectedError = `Cloud assembly schema version mismatch: Maximum schema version supported is ${currentSchemaVersion}, but found ${mockManifestVersion}.`
+ '\nPlease upgrade your CLI in order to interact with this app.';
const expectedError = 'This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version.'
+ `\n(Cloud assembly schema version mismatch: Maximum schema version supported is ${currentSchemaVersion}, but found ${mockManifestVersion})`;

config.settings.set(['app'], 'cdk.out');

Expand Down