Add a new s3 website command. #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command allows you to set the website configuration for a bucket. It currently only supports the index/error document. There's no support for routing rules.
| class TestWebsiteConfiguration(BaseS3CLICommand): | ||
| def test_create_website_configuration(self): | ||
| bucket_name = self.create_bucket() | ||
| full_command = 's3 website %s --index-document index.html' % (bucket_name) |
There was a problem hiding this comment.
Probably a good idea to test the error document, either here or in another test.
NVM, I see the tests below.
|
This looks much better than my version. |
Fixes the failing tests.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command allows you to set the website configuration for a bucket.
It currently only supports the index/error document. There's no support
for routing rules.