Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclic references. #24

Closed
wants to merge 1 commit into from

Conversation

shekharhimanshu
Copy link
Contributor

Looks like ClientCoreState has cyclic references inside action_map_ & outbound_action_queue_ which will cause memory leak as reported in #23 .

This hot-fix will resolve some of the issues reported.

@shekharhimanshu
Copy link
Contributor Author

shekharhimanshu commented Jun 27, 2017

Ideally cyclic references should be avoided. So please consider this as a hot fix only.
I would suggest brushing up class design or using weak_ptr to avoid cyclic references.

@chaurah
Copy link
Contributor

chaurah commented Jun 27, 2017

Hi @shekharhimanshu,
Thank you for this contribution. I think tweaking the design would make longer term sense here as you mention. I will look into what is possible while avoiding a delay for the next release. If a design change cannot be made without a breaking API change then I will include this hotfix in the next release.

Please do keep your suggestions coming. They have been very helpful.

Rahul

@vareddy-zz
Copy link
Contributor

Included in v1.1.1.

@vareddy-zz vareddy-zz closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants