Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parent project to specify dependency directory #8

Closed
wants to merge 6 commits into from

Conversation

lolsborn
Copy link

This change allows parent projects to determine where other dependencies should live by adding the following:

set(DEPENDENCY_DIR "vendors")

The reason for this is that the aws-iot-device-sdk-cpp library is likely already being installed along with other project dependencies. Currently aws-iot creates another directory at the top level of the parent project for it's dependencies. This is probably not desired for projects with existing dependencies and existing directory structure for third-party libraries.

Another option may be to simply ensure that the aws-iot dependencies are downloading in a subdirectory relative to itself and not the parent project.

This patch was made on top of @larsonmpdx's branch, but is not dependent upon it. I am happy to separate it out if necessary.

@chaurah
Copy link
Contributor

chaurah commented May 18, 2017

Hi @lolsborn,
Thank you for this contribution. You don't need to separate it out. We have already merged @larsonmpdx's patch internally. Your patch will also be included along with the next release of the SDK. Please do let us know if you have further suggestions.

Rahul

@chaurah
Copy link
Contributor

chaurah commented Jun 7, 2017

This pull request has been merged in v1.1 release of the SDK.
Rahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants