Remove Node14 from integ tests matrix since it is deprecated

aws · Feb 14, 2024 · f283247 · f283247
1 parent b6b3656
commit f283247
Show file tree

Hide file tree

Showing 13 changed files with 4 additions and 149 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,6 @@ You can include this package in your preferred base image to make that base imag
 
 ## Requirements
 The NodeJS Runtime Interface Client package currently supports NodeJS versions:
- - 14.x
  - 16.x
  - 18.x
  - 20.x

diff --git a/test/integration/codebuild/buildspec.os.alpine.1.yml b/test/integration/codebuild/buildspec.os.alpine.1.yml
@@ -16,7 +16,6 @@ batch:
           DISTRO_VERSION:
             - "3.16"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
 phases:

diff --git a/test/integration/codebuild/buildspec.os.alpine.2.yml b/test/integration/codebuild/buildspec.os.alpine.2.yml
@@ -16,9 +16,9 @@ batch:
       env:
         variables:
           DISTRO_VERSION:
-            - "3.16"
+            - "3.18"
           RUNTIME_VERSION:
-            - "14"
+            - "20"
 phases:
   pre_build:
     commands:

diff --git a/test/integration/codebuild/buildspec.os.alpine.4.yml b/test/integration/codebuild/buildspec.os.alpine.4.yml
diff --git a/test/integration/codebuild/buildspec.os.centos.yml b/test/integration/codebuild/buildspec.os.centos.yml
@@ -17,7 +17,6 @@ batch:
             - "stream8"
             - "stream9"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
             - "20"

diff --git a/test/integration/codebuild/buildspec.os.debian.1.yml b/test/integration/codebuild/buildspec.os.debian.1.yml
@@ -17,7 +17,6 @@ batch:
             - "buster"
             - "bullseye"
           RUNTIME_VERSION:
-            - "14"
             - "16"
             - "18"
             - "20"

diff --git a/test/integration/codebuild/buildspec.os.ubuntu.1.yml b/test/integration/codebuild/buildspec.os.ubuntu.1.yml
@@ -18,7 +18,6 @@ batch:
             - "20.04"
             - "22.04"
           RUNTIME_VERSION:
-            - "14"
             - "16"
 phases:
   pre_build:

diff --git a/test/integration/docker/Dockerfile.echo.alpine b/test/integration/docker/Dockerfile.echo.alpine
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.amazonlinux b/test/integration/docker/Dockerfile.echo.amazonlinux
@@ -12,16 +12,8 @@ ARG DISTRO_VERSION
 # Install Py3 required to build Node16+
 RUN if [[ "${DISTRO_VERSION}" == "2" ]] ; then amazon-linux-extras install python3.8 && update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 ; fi
 # Install NodeJS
-RUN if [[ "${RUNTIME_VERSION}" == "14" ]]; then \
-    yum install -y tar gzip xz && \
-    AARCH="$([[ "$(arch)" == "x86_64" ]] && echo "x64" || echo "arm64")" && \
-    NODE_URL="https://nodejs.org/download/release/v14.21.3/node-v14.21.3-linux-$AARCH.tar.xz" && \
-    curl -fL "$NODE_URL" | tar -C /usr --strip-components 1 -xJf - && \
-    yum clean all -q && rm -rf /var/cache/yum ; \
-else \
-    yum install https://rpm.nodesource.com/pub_${RUNTIME_VERSION}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y && \
-    yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1s ; \
-fi
+RUN yum install https://rpm.nodesource.com/pub_${RUNTIME_VERSION}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y && \
+    yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1s;
 
 # Stage 2 - build function and dependencies
 FROM node-amazonlinux AS build-image
@@ -50,11 +42,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.centos b/test/integration/docker/Dockerfile.echo.centos
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.debian b/test/integration/docker/Dockerfile.echo.debian
@@ -22,11 +22,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.echo.ubuntu b/test/integration/docker/Dockerfile.echo.ubuntu
@@ -48,11 +48,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit
 

diff --git a/test/integration/docker/Dockerfile.programmatic.alpine b/test/integration/docker/Dockerfile.programmatic.alpine
@@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
 WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
 COPY . .
 
-# Node14 uses npm@6.14.18 by default which will downgrade permissions, if it's root,
-# before running any build scripts: https://github.com/npm/npm/issues/3497 
-# Starting from npm@7.0.0, when npm is run as root, 
-# scripts are always run with the effective uid and gid of the working directory owner.
-RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
 RUN make build && \
     npm run test:unit