Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pregeneration of bindings #541

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Sep 27, 2024

Description of changes:

  • Rename environment variable to remove ambiguity: AWS_LC_SYS_INTERNAL_BINDGEN -> AWS_LC_SYS_PREGENERATING_BINDINGS
    • Rename associated (internal function): is_internal_bindgen() -> is_pregenerating_bindings()
  • Include aws-lc-fips-sys in our pregen-binding.yml CI workflow.
  • The generated-include directory should not be included when performing a no-prefix build
  • Cleanup the compiler_check logic.
  • Generate additional diagnostic warnings during build.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 27, 2024 16:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (fe43a79).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skmcgrail
skmcgrail previously approved these changes Sep 27, 2024
skmcgrail
skmcgrail previously approved these changes Sep 27, 2024
@justsmth justsmth merged commit 1a44d74 into aws:main Sep 27, 2024
232 of 233 checks passed
@justsmth justsmth deleted the fix-pregen-bindings branch September 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants