Add support for building with pkgconfig #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
pkgconfig
branch
from
af413bb
to
f4b69f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1310 +/- ##
==========================================
- Coverage 77.96% 76.36% -1.60%
==========================================
Files 530 421 -109
Lines 101077 70974 -30103
==========================================
- Hits 78805 54200 -24605
+ Misses 22272 16774 -5498 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
pkgconfig
branch
from
f4b69f1
to
7f56458
Compare
samuel40791765
force-pushed
the
pkgconfig
branch
from
7f56458
to
46459f2
Compare
justsmth
previously approved these changes
Nov 21, 2023
WillChilds-Klein
approved these changes
Nov 22, 2023
justsmth
approved these changes
Nov 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-2164Description of changes:
librelp, bind, and other libraries use package config to detect OpenSSL support. This lets these projects find AWS-LC with their existing configuration.
Call-outs:
Versioning still needs ironing out
Testing:
This can be tested once we add CI for librelp. This passes locally but we haven't ironed out all the details for librelp just yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.