Add FIPS aarch POC build to CI. #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove 'ep_nistz256_add' function, and change offset calculation. 'ep_nistz256_add' in p256-armv8-asm.pl is duplicate to p256-nistz.c. Removing 'ep_nistz256_add' function is to avoid delocate.go reporting 'Duplicate symbol found'. The offset calculation expression change is to avoid 'peg' parser errors because the current delocate.peg is not comprehensive enough to parse all assembly expressions. * Add new peg rules to address new assembly expression. * Change assembly expression. * Add delocate.peg convert README. * Remove auto-generated comment. * Add more delocate.peg.go generate commands. * Fix command. * Update build files in generated-src
* Remove 'ep_nistz256_add' function, and change offset calculation. 'ep_nistz256_add' in p256-armv8-asm.pl is duplicate to p256-nistz.c. Removing 'ep_nistz256_add' function is to avoid delocate.go reporting 'Duplicate symbol found'. The offset calculation expression change is to avoid 'peg' parser errors because the current delocate.peg is not comprehensive enough to parse all assembly expressions. * Add new peg rules to address new assembly expression. * Change assembly expression. * Add delocate.peg convert README. * Remove auto-generated comment. * Add more delocate.peg.go generate commands. * Fix command. * Add offset to local symbol in delocate. * Update util/fipstools/delocate/delocate.go Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com> * Update util/fipstools/delocate/delocate.go Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com> * Update comments. Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com>
dkostic
previously approved these changes
Apr 27, 2021
nebeid
reviewed
Apr 27, 2021
| compute-type: BUILD_GENERAL1_LARGE | ||
| image: ECR_REPO_PLACEHOLDER:ubuntu-20.04_clang-7x_latest | ||
| variables: | ||
| AWSLC_NO_ASM_FIPS: 1 |
There was a problem hiding this comment.
You probably answered this question before, Bryce; so this build will not use assembly files?
There was a problem hiding this comment.
The build includes multiple flavors -- both ASM and NOASM are enabled.
When NO_ASM, ASAN is enabled.
https://github.com/awslabs/aws-lc/blob/main/tests/ci/run_fips_tests.sh#L22
nebeid
previously approved these changes
Apr 27, 2021
|
Changes in |
nebeid
approved these changes
Apr 28, 2021
dkostic
approved these changes
Apr 28, 2021
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Add global assumptions paragraph s2n-bignum original commit: awslabs/s2n-bignum@d61796f
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Add global assumptions paragraph s2n-bignum original commit: awslabs/s2n-bignum@d61796f s2n-bignum original commit: awslabs/s2n-bignum@405230a
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
Add global assumptions paragraph s2n-bignum original commit: awslabs/s2n-bignum@d61796f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-725
Description of changes:
This PR added FIPS aarch build dimensions to awslc CI.
Call-outs:
CryptoAlg-723?selectedConversation=e0c5b7c9-60f5-4d30-a496-f5f8dbc711cdTesting:
CodeBuild request -aws-lc-ci-linux-arm:db6724d9-5b22-4f6f-a429-c0b552eec1f9go testtimeout, which is 10m.aws-lc-ci-linux-arm:8f624494-6ea8-46e2-b337-1f924dc40d03By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.